This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Add cri managed image label when pulling the image.#1162
Merged
Random-Liu merged 1 commit intocontainerd:masterfrom Jun 11, 2019
Merged
Add cri managed image label when pulling the image.#1162Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
added a commit
that referenced
this pull request
Jun 11, 2019
Cherrypick #1162 release 1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1161.
Add the cri managed image label when pulling the image.
Previously, we didn't add the image label when pulling the image, so the generated image create event also doesn't have the label:
The cri plugin will create/update the image reference to add the label, and this may happen after
PullImagereturns.If
RemoveImageis called right afterPullImage, there will be a race condition beforeRemoveImageand the event triggered image reference create/update. #1161 is caused just because the create/update happens after `RemoveImage.Signed-off-by: Lantao Liu [email protected]