Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Do not SIGKILL container if container stop is cancelled.#1099

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:do-not-kill-if-cancelled
Mar 27, 2019
Merged

Do not SIGKILL container if container stop is cancelled.#1099
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:do-not-kill-if-cancelled

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

Fixes #1098.

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the v1.0 milestone Mar 27, 2019
@Random-Liu
Copy link
Copy Markdown
Member Author

We should cherrypick this into supported branches.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

nice fix

@Random-Liu Random-Liu merged commit 8777224 into containerd:master Mar 27, 2019
@Random-Liu Random-Liu deleted the do-not-kill-if-cancelled branch March 27, 2019 21:55
@lbernail
Copy link
Copy Markdown

Thanks a lot!

Random-Liu added a commit that referenced this pull request Mar 29, 2019
Random-Liu added a commit that referenced this pull request Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants