This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Fix /etc/hostname backward compatibility issue for in-place upgrade.#1085
Merged
Random-Liu merged 1 commit intocontainerd:masterfrom Mar 12, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Member
Author
|
We should cherry-pick this into supported branches. And let's include the fix in 1.2.5 containerd/containerd#3086. |
This was referenced Mar 12, 2019
This was referenced Mar 12, 2019
Random-Liu
added a commit
that referenced
this pull request
Mar 12, 2019
Cherrypick #1085 release 1.2
Random-Liu
added a commit
that referenced
this pull request
Mar 12, 2019
Cherrypick #1085 release 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082.
If people do in-place upgrade, old sandboxes may not have the
hostnamefile. In that case, we shouldn't try to mount it into containers.Another option is to create the hostname file for the old sandbox if it doesn't have it. However, that also causes inconsistency, e.g. inside the same pod, old running containers don't have the hostname file, new restarted containers have it.
Neither of them is a perfect solution, skipping mounting is cleaner and keeps consistency inside the same pod, so I implemented that one.
Signed-off-by: Lantao Liu [email protected]