This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Use clean path for map and comparison.#1072
Merged
Random-Liu merged 1 commit intocontainerd:masterfrom Mar 4, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Member
Author
|
Apply LGTM based on #1072 (review) |
This was referenced Mar 4, 2019
Random-Liu
added a commit
that referenced
this pull request
Mar 5, 2019
Cherrypick #1072 release 1.0
Random-Liu
added a commit
that referenced
this pull request
Mar 5, 2019
Cherrypick #1072 release 1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1059.
Use
filepath.Cleanfor map deduplication and path comparison.I've searched with
git grep -i:==.*path,path.*==,\[.*path.*\],==.*source,source.*==,\[.*source.*\],==.*src,src.*==,\[.*src.*\],==.*dst,dst.*==,\[.*dst.*\],==.*dest,dest.*==,\[.*dest.*\]. And addedfilepath.Cleanfor all appearance.We should cherry-pick this fix into all supported branches.
Signed-off-by: Lantao Liu [email protected]