Add HOSTNAME to env by default for pod containers

estesp · estesp · commit 4c3e195db36e · 2018-09-05T12:04:40.000-04:00
To match expectations of users coming from Docker engine runtime, add
the HOSTNAME to the environment of new containers in a pod.

Signed-off-by: Phil Estes &lt;estesp@linux.vnet.ibm.com&gt;
diff --git a/pkg/server/container_create.go b/pkg/server/container_create.go
@@ -341,6 +341,8 @@ func (c *criService) generateContainerSpec(id string, sandboxID string, sandboxP
 	for _, e := range config.GetEnvs() {
 		g.AddProcessEnv(e.GetKey(), e.GetValue())
 	}
+	// add the HOSTNAME variable to the environment to match Docker runtime default
+	g.AddProcessEnv("HOSTNAME", sandboxConfig.GetHostname())
 
 	securityContext := config.GetLinux().GetSecurityContext()
 	selinuxOpt := securityContext.GetSelinuxOptions()

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,8 @@ func (c *criService) generateContainerSpec(id string, sandboxID string, sandboxP`
`341`	`341`	`for _, e := range config.GetEnvs() {`
`342`	`342`	`g.AddProcessEnv(e.GetKey(), e.GetValue())`
`343`	`343`	`}`
	`344`	`+ // add the HOSTNAME variable to the environment to match Docker runtime default`
	`345`	`+ g.AddProcessEnv("HOSTNAME", sandboxConfig.GetHostname())`
`344`	`346`
`345`	`347`	`securityContext := config.GetLinux().GetSecurityContext()`
`346`	`348`	`selinuxOpt := securityContext.GetSelinuxOptions()`