cmd/continuity/commands: MountCmd: remove macOS remnants#254
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Oct 26, 2024
Merged
cmd/continuity/commands: MountCmd: remove macOS remnants#254AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
commit 5df4731 removed support for fuse on macOS. macOS support was removed from this dependency in [bazil.org/fuse@60eaf8f], and these options were now a stub (see [1], [dummyOption]). [bazil.org/fuse@60eaf8f]: bazil/fuse@60eaf8f [1]: https://github.com/bazil/fuse/blob/fb710f7dfd05053a3bc9516dd5a7a8f84ead8aab/options.go#L70-L98 [dummyOption]: https://github.com/bazil/fuse/blob/fb710f7dfd05053a3bc9516dd5a7a8f84ead8aab/options.go#L7-L9 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@AkihiroSuda github doesn't link 5df4731 to a PR; was that an accidental push to upstream, or is GitHub behaving badly? 🙈 ❤️ |
Member
Yes, sorry
|
AkihiroSuda
reviewed
Oct 26, 2024
| c.Close() | ||
| log.L.Fatal(err) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
(got it, seems no longer supported in the latest fuse)
AkihiroSuda
approved these changes
Oct 26, 2024
Member
Author
❤️ no worries, 💩 happens; I was just confused (normally I link to the PR for easier discovery |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 5df4731 removed support for fuse on macOS. macOS support was removed from this dependency in bazil.org/fuse@60eaf8f, and these options were now a stub (see 1, dummyOption).