Skip to content

switch to github.com/containerd/log module#243

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
thaJeztah:switch_to_log
Oct 26, 2024
Merged

switch to github.com/containerd/log module#243
AkihiroSuda merged 1 commit intocontainerd:mainfrom
thaJeztah:switch_to_log

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

No description provided.

@thaJeztah thaJeztah self-assigned this Jun 22, 2024
@thaJeztah thaJeztah closed this Jul 25, 2024
@thaJeztah thaJeztah reopened this Jul 25, 2024
@AkihiroSuda AkihiroSuda reopened this Oct 20, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

Please rebase to pass the CI

@thaJeztah thaJeztah requested a review from AkihiroSuda October 25, 2024 22:20
require github.com/stretchr/testify v1.3.0 // indirect
require (
github.com/sirupsen/logrus v1.9.3 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containerd/log doesn't seem to depend on yaml 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's through testify;

go mod graph | grep ' gopkg.in/yaml.v3'
github.com/containerd/continuity gopkg.in/[email protected]
github.com/stretchr/[email protected] gopkg.in/[email protected]

Which is depended on through logrus;

go mod graph | grep ' github.com/stretchr/[email protected]'
github.com/sirupsen/[email protected] github.com/stretchr/[email protected]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I think I know what happened; it can be removed indeed. The v3.0.0-20200313102051-9f266ea9e77c -> v3.0.1 may have been either a manual bump (to prevent an old version with CVEs), or possibly stuck after it was updated indirectly. Go mod doesn't remove such lines automatically, but it doesn't add them back if you remove them manually; it's worth sometimes removing all the // indirect dependencies, and see if there's ones that are actually gone.

let me open a PR to get rid of it.

@AkihiroSuda AkihiroSuda merged commit 898d7ed into containerd:main Oct 26, 2024
@thaJeztah thaJeztah deleted the switch_to_log branch October 26, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants