Skip to content

support filesystem magic for linux#239

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
yylt:magic
Apr 6, 2024
Merged

support filesystem magic for linux#239
AkihiroSuda merged 1 commit intocontainerd:mainfrom
yylt:magic

Conversation

@yylt
Copy link
Copy Markdown
Contributor

@yylt yylt commented Apr 3, 2024

Related to containerd/containerd#5859

File filesystem magic number is general operation, so it is placed here.

@yylt
Copy link
Copy Markdown
Contributor Author

yylt commented Apr 3, 2024

@AkihiroSuda

)

// GetFSMagic returns the filesystem id given the path.
func GetFSMagic(rootpath string) (FsMagic, error) {
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func GetFSMagic(rootpath string) (FsMagic, error) {
func GetFsMagic(rootPath string) (FsMagic, error) {

*/

/*
Copyright 2013-2018 Docker, Inc.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a permanent link to the original file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yylt yylt force-pushed the magic branch 3 times, most recently from 2344e2b to a87d007 Compare April 3, 2024 12:31
limitations under the License.
*/

// Original source: https://github.com/moby/moby/blob/master/daemon/graphdriver/driver_linux.go
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace "master" with the actual version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants