Support FreeBSD#173
Merged
estesp merged 6 commits intocontainerd:masterfrom Dec 8, 2020
Merged
Conversation
samuelkarp
force-pushed
the
freebsd
branch
3 times, most recently
from
fdcd9a7 to
f92a56d
Compare
mxpv
reviewed
Dec 7, 2020
Member
mxpv
left a comment
mxpv
left a comment
There was a problem hiding this comment.
I have a suggestion on file naming, but otherwise LGTM
Member
|
I think making sure it compiles is at least important, and maybe a callout in the readme that freebsd support is untested. |
FreeBSD 12 added support for 64-bit inodes, introducing an ABI change. golang.org/x/sys/unix was updated for this change, and the function signature for unix.Mknod changed on FreeBSD. See golang/sys@5535b4e Signed-off-by: Samuel Karp <[email protected]>
The utimes syscall follows symlinks and changes the times on the link target, rather than the link itself. The lutimes syscall can be used to modify times on a symlink, though both syscalls are deprecated in favor of utimensat. utimensat can be called with the AF_SYMLINK_NOFOLLOW flag to change the times on a symlink. Signed-off-by: Samuel Karp <[email protected]>
The FreeBSD du(1) command accepts block size argument via an environment variable (BLOCKSIZE) rather than the --block-size argument used in the GNU coreutils version of du(1). Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Member
Author
Added to ci.yml
I took a stab at wording, but I'm happy to change it if there are any other opinions. |
mxpv
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of commits adds support for FreeBSD. Aside from
TestUsagefailing on ZFS (see #172), all the tests are passing.Some of the files are pretty awkwardly-named; if you have suggestions for changing them I'm happy to do so.
I recognize that there's no CI coverage for FreeBSD today (though adding at least cross-compiling to CI would be reasonably straightforward) and that there may not be interest in maintaining the code. If that's the case and you prefer not to merge this, I can maintain my own usage of it on my fork.