Skip to content

go.mod: github.com/golang/protobuf v1.3.5#158

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:update_protobuf
Mar 13, 2021
Merged

go.mod: github.com/golang/protobuf v1.3.5#158
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:update_protobuf

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Sep 17, 2020

Follow-up to #157; only the last commit (92bffbb) is new. This version matches what's used in containerd and buildkit, and Cobra 1.0 depends on protobuf > v1.3.1

Keeping this separate, as it may have to be reviewed separately

@thaJeztah thaJeztah marked this pull request as ready for review September 28, 2020 17:42
@thaJeztah
Copy link
Copy Markdown
Member Author

this one should also be ready for review @estesp @dmcgowan (sorry for the multiple PR's, trying to somewhat keep changes reviewable)

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

@AkihiroSuda @dmcgowan ptal

1 similar comment
@thaJeztah
Copy link
Copy Markdown
Member Author

@AkihiroSuda @dmcgowan ptal

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda AkihiroSuda merged commit 968621f into containerd:master Mar 13, 2021
@thaJeztah thaJeztah deleted the update_protobuf branch March 13, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants