split testutil/loopback_linux.go to another pkg #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd/containerd#2694 is going to import both `containerd/pkg/testutil` and `continuity/testutil` for deduplicating `NewLoopback()`. However, as the both pkg defines `test.root` BoolVar in `init()`, the test panics. This commit avoids the panic issue by splitting `continuity/testutil/loopback_linux.go` to another pkg (`continuity/testutil/loopback`), so taht containerd does not need to import both `containerd/pkg/testutil` and `continuity/testutil`. i.e. containerd will import `containerd/pkg/testutil` and `continuity/testutil/loopback`. Signed-off-by: Akihiro Suda <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerd/containerd#2694 is going to import both
containerd/pkg/testutilandcontinuity/testutilfor deduplicatingNewLoopback().However, as the both pkg defines
test.rootBoolVar ininit(), the test panics.This commit avoids the panic issue by splitting
continuity/testutil/loopback_linux.goto another pkg (
continuity/testutil/loopback), so taht containerd does not need to importboth
containerd/pkg/testutilandcontinuity/testutil.i.e. containerd will import
containerd/pkg/testutilandcontinuity/testutil/loopback.Signed-off-by: Akihiro Suda [email protected]