Export copyFile
#106
Merged
Export copyFile
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
approved these changes
Feb 14, 2018
|
Where is this planned on being used? I know we had some plans for this and possibly merging it with some functionality for buildkit's fsutil and Moby. I am fine merging this and changing it later if we need to though. LGTM |
|
I was going to use this for something... what I don't remember... maybe it was in moby. |
stevvooe
reviewed
Apr 6, 2018
fs/copy.go
Outdated
| func copyFile(source, target string) error { | ||
| // CopyFile copies the source file to the target. | ||
| // The most efficient means of copying is used for the platform. | ||
| func CopyFile(source, target string) error { |
There was a problem hiding this comment.
We usually use LHS notation for the args in this package.
Should be CopyFile(target, source string)
Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
export_copy_file
branch
from
389ac27 to
d59f454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.