reformat nolint comments

thaJeztah · thaJeztah · commit fa7d1622372f · 2021-06-22T16:22:50.000+02:00
Unlike comments for "humans", nolint comments should not have a leading
whitespace.

Also combined some comments, and renamed local variables so that we don't
have to suppress linting warnings for those.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/fs/du_unix.go b/fs/du_unix.go
@@ -41,10 +41,8 @@ type inode struct {
 
 func newInode(stat *syscall.Stat_t) inode {
 	return inode{
-		// Dev is uint32 on darwin/bsd, uint64 on linux/solaris/freebsd
-		dev: uint64(stat.Dev), // nolint: unconvert
-		// Ino is uint32 on bsd, uint64 on darwin/linux/solaris/freebsd
-		ino: uint64(stat.Ino), // nolint: unconvert
+		dev: uint64(stat.Dev), //nolint: unconvert // dev is uint32 on darwin/bsd, uint64 on linux/solaris/freebsd
+		ino: uint64(stat.Ino), //nolint: unconvert // ino is uint32 on bsd, uint64 on darwin/linux/solaris/freebsd
 	}
 }
 
diff --git a/fs/du_unix_test.go b/fs/du_unix_test.go
@@ -34,7 +34,7 @@ func getBsize(root string) (int64, error) {
 		return 0, err
 	}
 
-	return int64(s.Bsize), nil // nolint: unconvert
+	return int64(s.Bsize), nil //nolint: unconvert
 }
 
 // getTmpAlign returns filesystem specific size alignment functions
@@ -92,6 +92,6 @@ func duCheck(root string) (usage int64, err error) {
 	if err != nil {
 		return 0, err
 	}
-	return blocks * blocksUnitSize, nil
 
+	return blocks * blocksUnitSize, nil
 }
diff --git a/fs/hardlink_unix.go b/fs/hardlink_unix.go
@@ -29,6 +29,5 @@ func getLinkInfo(fi os.FileInfo) (uint64, bool) {
 		return 0, false
 	}
 
-	// Ino is uint32 on bsd, uint64 on darwin/linux/solaris
-	return uint64(s.Ino), !fi.IsDir() && s.Nlink > 1 // nolint: unconvert
+	return uint64(s.Ino), !fi.IsDir() && s.Nlink > 1 //nolint: unconvert // ino is uint32 on bsd, uint64 on darwin/linux/solaris
 }
diff --git a/manifest.go b/manifest.go
@@ -75,7 +75,7 @@ func MarshalText(w io.Writer, m *Manifest) error {
 // BuildManifest creates the manifest for the given context
 func BuildManifest(ctx Context) (*Manifest, error) {
 	resourcesByPath := map[string]Resource{}
-	hardlinks := newHardlinkManager()
+	hardLinks := newHardlinkManager()
 
 	if err := ctx.Walk(func(p string, fi os.FileInfo, err error) error {
 		if err != nil {
@@ -97,7 +97,7 @@ func BuildManifest(ctx Context) (*Manifest, error) {
 		}
 
 		// add to the hardlink manager
-		if err := hardlinks.Add(fi, resource); err == nil {
+		if err := hardLinks.Add(fi, resource); err == nil {
 			// Resource has been accepted by hardlink manager so we don't add
 			// it to the resourcesByPath until we merge at the end.
 			return nil
@@ -114,14 +114,12 @@ func BuildManifest(ctx Context) (*Manifest, error) {
 	}
 
 	// merge and post-process the hardlinks.
-	// nolint:misspell
-	hardlinked, err := hardlinks.Merge()
+	hardLinked, err := hardLinks.Merge()
 	if err != nil {
 		return nil, err
 	}
 
-	// nolint:misspell
-	for _, resource := range hardlinked {
+	for _, resource := range hardLinked {
 		resourcesByPath[resource.Path()] = resource
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -41,10 +41,8 @@ type inode struct {`
`41`	`41`
`42`	`42`	`func newInode(stat *syscall.Stat_t) inode {`
`43`	`43`	`return inode{`
`44`		`- // Dev is uint32 on darwin/bsd, uint64 on linux/solaris/freebsd`
`45`		`- dev: uint64(stat.Dev), // nolint: unconvert`
`46`		`- // Ino is uint32 on bsd, uint64 on darwin/linux/solaris/freebsd`
`47`		`- ino: uint64(stat.Ino), // nolint: unconvert`
	`44`	`+ dev: uint64(stat.Dev), //nolint: unconvert // dev is uint32 on darwin/bsd, uint64 on linux/solaris/freebsd`
	`45`	`+ ino: uint64(stat.Ino), //nolint: unconvert // ino is uint32 on bsd, uint64 on darwin/linux/solaris/freebsd`
`48`	`46`	`}`
`49`	`47`	`}`
`50`	`48`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func getBsize(root string) (int64, error) {`
`34`	`34`	`return 0, err`
`35`	`35`	`}`
`36`	`36`
`37`		`- return int64(s.Bsize), nil // nolint: unconvert`
	`37`	`+ return int64(s.Bsize), nil //nolint: unconvert`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`// getTmpAlign returns filesystem specific size alignment functions`
`@@ -92,6 +92,6 @@ func duCheck(root string) (usage int64, err error) {`
`92`	`92`	`if err != nil {`
`93`	`93`	`return 0, err`
`94`	`94`	`}`
`95`		`- return blocks * blocksUnitSize, nil`
`96`	`95`
	`96`	`+ return blocks * blocksUnitSize, nil`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,5 @@ func getLinkInfo(fi os.FileInfo) (uint64, bool) {`
`29`	`29`	`return 0, false`
`30`	`30`	`}`
`31`	`31`
`32`		`- // Ino is uint32 on bsd, uint64 on darwin/linux/solaris`
`33`		`- return uint64(s.Ino), !fi.IsDir() && s.Nlink > 1 // nolint: unconvert`
	`32`	`+ return uint64(s.Ino), !fi.IsDir() && s.Nlink > 1 //nolint: unconvert // ino is uint32 on bsd, uint64 on darwin/linux/solaris`
`34`	`33`	`}`