[release/1.6] Update builds to go 1.21.8#9945
Merged
estesp merged 1 commit intocontainerd:release/1.6from Mar 8, 2024
Merged
Conversation
AkihiroSuda
changed the title
austinvazquez
approved these changes
Mar 7, 2024
akhilerm
reviewed
Mar 7, 2024
| # Go version we currently use to build containerd across all CI. | ||
| # Note: don't forget to update `Binaries` step, as it contains the matrix of all supported Go versions. | ||
| GO_VERSION: "1.20.13" | ||
| GO_VERSION: "1.21.8" |
Member
There was a problem hiding this comment.
I think we missed one change in #9890. Because after setting up composite action, we should not be setting GO_VERSION env in the workflow file.
Member
Author
There was a problem hiding this comment.
Included the missing change in the action now, but this file doesn't seem to be updated to use the action
Member
There was a problem hiding this comment.
I have added one more commit to fix the linter issues
Member
|
Looks like the changes to use the composite action were dropped again in the push. |
Member
Author
|
@austinvazquez I removed it, CI was failing. We can update that in a follow up. |
estesp
approved these changes
Mar 8, 2024
dmcgowan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to:
Carry #9934