[release/1.7] update to go 1.21.6, test 1.22.0#9860
Merged
AkihiroSuda merged 7 commits intocontainerd:release/1.7from Mar 5, 2024
Merged
[release/1.7] update to go 1.21.6, test 1.22.0#9860AkihiroSuda merged 7 commits intocontainerd:release/1.7from
AkihiroSuda merged 7 commits intocontainerd:release/1.7from
Conversation
akhilerm
force-pushed
the
update-go-version-1.7
branch
2 times, most recently
from
8179657 to
4b8b3e6
Compare
akhilerm
force-pushed
the
update-go-version-1.7
branch
3 times, most recently
from
4ed8a6f to
d93337a
Compare
Signed-off-by: Maksym Pavlenko <[email protected]> (cherry picked from commit 488b563) Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]> (cherry picked from commit 2820343) Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]> (cherry picked from commit 360fbf1) Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
update-go-version-1.7
branch
2 times, most recently
from
e027ef4 to
f0c20e9
Compare
akhilerm
force-pushed
the
update-go-version-1.7
branch
from
985510c to
c2835c8
Compare
Signed-off-by: Kirtana Ashok <[email protected]> (cherry picked from commit 87aa9e8) Signed-off-by: Akhil Mohan <[email protected]>
Tests in pkg/cri/[sb]server/container_create_linux_test.go depends on go:noinline since Go 1.21. e.g., > ``` > === FAIL: pkg/cri/sbserver TestGenerateSeccompSecurityProfileSpecOpts/should_set_default_seccomp_when_seccomp_is_runtime/default (0.00s) > container_create_linux_test.go:1013: > Error Trace: /home/runner/work/containerd/containerd/pkg/cri/sbserver/container_create_linux_test.go:1013 > Error: Not equal: > expected: 0x263d880 > actual : 0x263cbc0 > Test: TestGenerateSeccompSecurityProfileSpecOpts/should_set_default_seccomp_when_seccomp_is_runtime/default > ``` See comments in PR 8957. Thanks to Wei Fu for analyzing this. Co-authored-by: Wei Fu <[email protected]> Signed-off-by: Akihiro Suda <[email protected]> (cherry picked from commit 0f043ae) Signed-off-by: Akhil Mohan <[email protected]>
The default version of MinGW and GCC on the GitHub-hosted Windows 2019 runners compile fine but lead to linker errors during runtime. Signed-off-by: Nashwan Azhari <[email protected]> (cherry picked from commit c883410) Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Kirtana Ashok <[email protected]> (cherry picked from commit 21640c5) Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
update-go-version-1.7
branch
from
aa635a9 to
3b3e537
Compare
akhilerm
changed the title
estesp
approved these changes
Mar 4, 2024
mxpv
approved these changes
Mar 5, 2024
AkihiroSuda
approved these changes
Mar 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go1.21.6 (released 2024-01-09) includes fixes to the compiler, the runtime, and the crypto/tls, maps, and runtime/pprof packages. See the Go 1.21.6 milestone on our issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.21.6+label%3ACherryPickApproved
go1.22.0 (released 2024-02-06) Go 1.22.0 is a major release of Go. Read the Go 1.22 Release Notes for more information. https://go.dev/doc/go1.22
Cherry picks :
Notes for reviewers
The PR has lot of cherry pick commits because all the related commits to build / test and run the CI on go1.21.0 are currently dependent on the changes in the other cherry-picks. The only PR that could be cherry-picked independently was Extract setup-go step into composite action #9786, but that would again require changes as it was built on top of go1.21.x . Hence combining all the commits.
go version is kept at 1.21.6 since main is also on 1.21.6, and there is a security release on March 5 for 1.21.8. Hence the main, and release branches can be updated to 1.21.8 together.
Follow up cherry-pick of [CI] Move inline PS scripts into files #9777 will be done once this PR is merged.