Skip to content

[release/1.7] cri: propagate deprecation list to runtime status#9818

Merged
mikebrow merged 1 commit intocontainerd:release/1.7from
AkihiroSuda:cherrypick-9767-1.7
Feb 14, 2024
Merged

[release/1.7] cri: propagate deprecation list to runtime status#9818
mikebrow merged 1 commit intocontainerd:release/1.7from
AkihiroSuda:cherrypick-9767-1.7

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Propagate the deprecation list to CRI runtime conditions.

The propagated conditions are visible via `crictl info`,
but not visible via `kubectl get nodes -o yaml` yet, although
the CRI API says "These conditions will be exposed to users to help
them understand the status of the system".

https://github.com/kubernetes/cri-api/blob/v0.29.1/pkg/apis/runtime/v1/api.proto#L1505-L1509

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 1b3a96d)
(cherry-pick was not clean)
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added the area/cri Container Runtime Interface (CRI) label Feb 14, 2024
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 61cb5d3 into containerd:release/1.7 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants