Skip to content

Remove internal LoopConfig struct#9813

Merged
fuweid merged 1 commit intocontainerd:mainfrom
UiPath:remove-loop-config
Feb 13, 2024
Merged

Remove internal LoopConfig struct#9813
fuweid merged 1 commit intocontainerd:mainfrom
UiPath:remove-loop-config

Conversation

@alex-matei
Copy link
Copy Markdown
Contributor

@alex-matei alex-matei commented Feb 13, 2024 •
edited
Loading

The struct is now part of sys, I forgot to remove it in the previous PR.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 13, 2024

Hi @alex-matei. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akhilerm
akhilerm approved these changes Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you add in the description that this is a followup of #9805

LGTM

@alex-matei
Remove internal LoopConfig struct
ccec1e6 
The struct is now part of golang.org/x/sys.
Follow-up for containerd#9805

Signed-off-by: Alexandru Matei <[email protected]>
@alex-matei
Copy link
Copy Markdown
Contributor Author

alex-matei commented Feb 13, 2024

nit: Can you add in the description that this is a followup of #9805

LGTM

Done.

@fuweid fuweid added this pull request to the merge queue Feb 13, 2024
Merged via the queue into containerd:main with commit 81965c0 Feb 13, 2024
@austinvazquez austinvazquez mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilerm akhilerm akhilerm approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alex-matei @k8s-ci-robot @akhilerm @AkihiroSuda @fuweid