Skip to content

test: update upgrade test suite in integration #9748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estesp merged 7 commits into from
Feb 16, 2024
Merged

test: update upgrade test suite in integration #9748

estesp merged 7 commits into from
Feb 16, 2024

Conversation

@fuweid
Copy link
Member

@fuweid fuweid commented Feb 5, 2024

Summary:

  • Add some helper functions to reduce duplicate code in upgrade testsuite
  • Change Runtime.Status proto so that we can dump CRI configuration by API
  • Add some checkers to ensure there is no leaky resources after upgrade
  • Add failpoint in existing recover case: new release containerd should take over dead shim correctly
  • Add new case to check new release containerd can parse metric data from existing shim created by previous release.

Closes: #3757

NOTE: We should create new issue to track test suite in windows platform. For linux, I think we can close #3757 if this one is acceptable.

@fuweid fuweid added this to the 2.0 milestone Feb 5, 2024
@fuweid
integration: add some helper function to release upgrade cases
401d4b4 
Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration/*: extend Runtime.Status response
ec759f5 
CRI Runtime Status contains `Info` and it can help us check current
configuration.

Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration: check data dir after delete container or pod
a95c8ed 
The new release containerd should cleanup old pod's data dir after
RemovePodSandbox.

Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration: introduce hook for upgrade test suite
51689b6 
We can inject failpoint in beforeUpgradeHookFunc.

Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration: connect to shim by bridge client
e659cd2 
Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration: update recover case for upgrade
acec60f 
The new release containerd should detect dead shim during recover.

Signed-off-by: Wei Fu <[email protected]>
@fuweid
integration: add case related to ContainerStats in upgrade suite
c86c8a1 
It's used to check new release containerd can parse metric data from existing
shim created by previous release.

Signed-off-by: Wei Fu <[email protected]>
mikebrow
mikebrow approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
do we need to modify / create any upgrade docs to reflect a need to verify we have drained the node first?

@estesp estesp added this pull request to the merge queue Feb 16, 2024
Merged via the queue into containerd:main with commit 0f5586e Feb 16, 2024
@fuweid fuweid deleted the upgrade-testcase branch February 17, 2024 00:43
@fuweid
Copy link
Member Author

fuweid commented Feb 17, 2024

@mikebrow

do we need to modify / create any upgrade docs to reflect a need to verify we have drained the node first?

I think we can revisit all impact/changelog changes and then update docs if we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

ok-to-test size/XL

Projects

Pull Request Review
Archived in project

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Add binary upgrade tests

5 participants

@fuweid @mxpv @estesp @mikebrow @k8s-ci-robot