Skip to content

Update container-device-interface to v0.6.2#9677

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
elezar:dependency-update-container-device-interface-v0.6.2
Jan 23, 2024
Merged

Update container-device-interface to v0.6.2#9677
dmcgowan merged 1 commit intocontainerd:mainfrom
elezar:dependency-update-container-device-interface-v0.6.2

Conversation

@elezar
Copy link
Copy Markdown
Contributor

@elezar elezar commented Jan 23, 2024

This includes migrating from the github.com/container-orchestrated-devices repo to tags.cncf.io.

See cncf-tags/container-device-interface#176

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 23, 2024

Hi @elezar. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elezar
Update container-device-interface to v0.6.2
9dd29b3 
This includes migrating from the github.com/container-orchestrated-devices
repo to tags.cncf.io.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar force-pushed the dependency-update-container-device-interface-v0.6.2 branch from dea9143 to 9dd29b3 Compare January 23, 2024 10:36
@elezar
Copy link
Copy Markdown
Contributor Author

elezar commented Jan 23, 2024

/cc @AkihiroSuda

This would be required before continuing with containerd/nerdctl#2280

AkihiroSuda
AkihiroSuda approved these changes Jan 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the 2.0 milestone Jan 23, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jan 23, 2024

/ok-to-test

@elezar elezar mentioned this pull request Jan 23, 2024
Closed
10 tasks
@elezar
Copy link
Copy Markdown
Contributor Author

elezar commented Jan 23, 2024

/test pull-containerd-node-e2e

@elezar
Copy link
Copy Markdown
Contributor Author

elezar commented Jan 23, 2024

As a general quesion: How do we get this backported to the release-1.7 branch?

@AkihiroSuda AkihiroSuda added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label Jan 23, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jan 23, 2024

As a general quesion: How do we get this backported to the release-1.7 branch?

Feel free to submit a PR to that branch when this PR gets merged

@dmcgowan dmcgowan added this pull request to the merge queue Jan 23, 2024
Merged via the queue into containerd:main with commit 8e1578e Jan 23, 2024
@elezar elezar deleted the dependency-update-container-device-interface-v0.6.2 branch January 24, 2024 13:41
This was referenced Jan 24, 2024
Merged
Merged
@samuelkarp samuelkarp added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test size/XL

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@elezar @k8s-ci-robot @AkihiroSuda @dmcgowan @samuelkarp