Skip to content

[release/1.6 backport] remove github.com/opencontainers/runc dependency#9606

Merged
fuweid merged 1 commit intocontainerd:release/1.6from
thaJeztah:1.6_backport_switch_moby_user
Jan 8, 2024
Merged

[release/1.6 backport] remove github.com/opencontainers/runc dependency#9606
fuweid merged 1 commit intocontainerd:release/1.6from
thaJeztah:1.6_backport_switch_moby_user

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

I skipped intermediate runc updates, as it would be removed, so there was no need to include those.

This migrates uses of github.com/opencontainers/runc/libcontainer/user to the new github.com/moby/sys/user module, which was extracted from runc at commit opencontainers/runc@a3a0ec48c464fe6458d2ba067f6707c027e5384e.

This is the initial release of the module, which is a straight copy, but some changes may be made in the next release (such as fixing camel-casing in some fields and functions (Uid -> UID).

(cherry picked from commit 4b1bb12)

This migrates uses of github.com/opencontainers/runc/libcontainer/user
to the new github.com/moby/sys/user module, which was extracted from
runc at commit [opencontainers/runc@a3a0ec4].

This is the initial release of the module, which is a straight copy, but
some changes may be made in the next release (such as fixing camel-casing
in some fields and functions (Uid -> UID).

[opencontainers/runc@a3a0ec4]: opencontainers/runc@a3a0ec4

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 4b1bb12)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah requested a review from AkihiroSuda January 5, 2024 13:52
@thaJeztah thaJeztah self-assigned this Jan 5, 2024
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 4818395 into containerd:release/1.6 Jan 8, 2024
@thaJeztah thaJeztah deleted the 1.6_backport_switch_moby_user branch January 8, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants