Hi @milas. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

WithHTTPRequest could be replaced by function which wraps the transport. It looks like a much better interface to directly use the transport rather than request wrapping. We don't want to directly import the otel libraries from the resolve code though, we would like to reserve the ability to compile them out with tags if needed or at a minimum contain the otel library madness to the tracing package.

I assume these changes will need to get merged into main first as well.

WithHTTPRequest could be replaced by function which wraps the transport

Do you mean literally delete the function? While it's now useless, it's technically an exported function, so I didn't want to risk removing it, but if strict SemVer adherence isn't critical, then I'm happy to drop it.

We don't want to directly import the otel libraries from the resolve code though

ACK - is a tracing.WithHTTPTransport() func wrapper in the containerd/tracing package reasonable?

I assume these changes will need to get merged into main first as well.

Yes, definitely. Things are in a bad state in both 1.7 and 2.0/main, unfortunately 😭

I am starting with 1.7 because I'm using this commit in a WIP branch on moby/buildkit as well; I want to get a setup with functioning containerd + BuildKit + Moby tracing off their respective compatible branches, and once I know everything is working nicely together, do the PR dances to get things to the right branches.

Do you mean literally delete the function? While it's now useless, it's technically an exported function, so I didn't want to risk removing it, but if strict SemVer adherence isn't critical, then I'm happy to drop it.

I mean more the following suggestion of adding a new function. In main you can have a second commit which doesn't get backported to remove it since the next version will be 2.0.

ACK - is a tracing.WithHTTPTransport() func wrapper in the containerd/tracing package reasonable?

Seems like a reasonable interface

Carried in #9483

Thank you for getting this over the line!