Skip to content

fix: podsandbox depends on Lease plugin#9392

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
fuweid:fix-ci
Nov 17, 2023
Merged

fix: podsandbox depends on Lease plugin#9392
dmcgowan merged 1 commit intocontainerd:mainfrom
fuweid:fix-ci

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Nov 17, 2023 •
edited
Loading

introduced by 09723a6

The lease plugin doesn't have service type. So, like image/container apis, they needs lease plugin.

=== CONT  TestCRIImagePullTimeout/HoldingContentOpenWriter
    log_hook.go:47: time="2023-11-17T23:32:54.448668709+08:00" level=info msg="metadata content store policy set" func=plugin.init.1.func1 file="/home/fuwei/go/src/github.com/containerd/containerd/metadata/plugin/plugin.go:134" policy=shared testcase=TestCRIImagePullTimeout/HoldingContentOpenWriter
    build_local_containerd_helper_test.go:120:
                Error Trace:    /home/fuwei/go/src/github.com/containerd/containerd/integration/build_local_containerd_helper_test.go:120
                                                        /home/fuwei/go/src/github.com/containerd/containerd/integration/image_pull_timeout_test.go:113
                Error:          Received unexpected error:
                                unable to load CRI service base dependencies: failed to get "io.containerd.lease.v1" plugin: no plugins registered for io.containerd.lease.v1: plugin: not found
                Test:           TestCRIImagePullTimeout/HoldingContentOpenWriter
    build_local_containerd_helper_test.go:120:
                Error Trace:    /home/fuwei/go/src/github.com/containerd/containerd/integration/build_local_containerd_helper_test.go:120
                                                        /home/fuwei/go/src/github.com/containerd/containerd/integration/image_pull_timeout_test.go:113
                Error:          Received unexpected error:
                                unable to load CRI service base dependencies: failed to get "io.containerd.lease.v1" plugin: no plugins registered for io.containerd.lease.v1: plugin: not found
                Test:           TestCRIImagePullTimeout/HoldingContentOpenWriter
    build_local_containerd_helper_test.go:132:
                Error Trace:    /home/fuwei/go/src/github.com/containerd/containerd/integration/build_local_containerd_helper_test.go:132
                                                        /home/fuwei/go/src/github.com/containerd/containerd/integration/image_pull_timeout_test.go:113
                Error:          Received unexpected error:
                                unable to load CRI service base dependencies: failed to get "io.containerd.lease.v1" plugin: no plugins registered for io.containerd.lease.v1: plugin: not found
                Test:           TestCRIImagePullTimeout/HoldingContentOpenWriter

@fuweid fuweid mentioned this pull request Nov 17, 2023
Merged
@dmcgowan dmcgowan added this pull request to the merge queue Nov 17, 2023
Merged via the queue into containerd:main with commit 01f3937 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@mxpv mxpv mxpv approved these changes

@henry118 henry118 henry118 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fuweid @dmcgowan @mxpv @henry118