Skip to content

[release/1.6] vendor: github.com/emicklei/go-restful v2.16.0#9388

Closed
Kern-- wants to merge 1 commit intocontainerd:release/1.6from
Kern--:1.6-go-restful
Closed

[release/1.6] vendor: github.com/emicklei/go-restful v2.16.0#9388
Kern-- wants to merge 1 commit intocontainerd:release/1.6from
Kern--:1.6-go-restful

Conversation

@Kern--
Copy link
Copy Markdown

@Kern-- Kern-- commented Nov 16, 2023

govulncheck reports a vulnerability in go-restful in the 1.6 release:

Vulnerability #3: GO-2022-0619
    Authorization bypass in github.com/emicklei/go-restful, go-restful/v2 and
    go-restful/v3
  More info: https://pkg.go.dev/vuln/GO-2022-0619
  Module: github.com/emicklei/go-restful
    Found in: github.com/emicklei/[email protected]+incompatible
    Fixed in: github.com/emicklei/[email protected]+incompatible
    Example traces found:
      #1: restful.CrossOriginResourceSharing.Filter

Containerd has a direct dependency on go-restful/v3 that is not affected by this bug since a322077, but the error is coming from a transitive depdendency in k8s.io/apiserver:

$ go mod why github.com/emicklei/go-restful
# github.com/emicklei/go-restful
github.com/containerd/containerd/pkg/cri/streaming/portforward
k8s.io/apiserver/pkg/server/httplog
k8s.io/apiserver/pkg/endpoints/metrics
github.com/emicklei/go-restful

This change updates the transitive dependency to contain the fix.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 16, 2023

Hi @Kern--. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Kern--
Copy link
Copy Markdown
Author

Kern-- commented Nov 16, 2023

Oh, whoops. Looks like this is a duplicate of #9385.

@Kern-- Kern-- closed this Nov 16, 2023
@thaJeztah thaJeztah mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kern-- @k8s-ci-robot