-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[release/1.6] Expose usage of cri-api v1alpha2 #9357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruiwen-zhao
commented
Nov 9, 2023
- Backports [release/1.7] Expose usage of cri-api v1alpha2 #9336
- For Deprecation warnings #9312
Signed-off-by: ruiwen-zhao <[email protected]>
|
Hi @ruiwen-zhao. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@ruiwen-zhao: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test (I don't know why you still need this?) |
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting this is 1.6 and v1alpha2 was not officially deprecated here..
Thought it. says 1.7 :-) so the warning is still accurate, if not odd to be adding to 1.6.
Hmm
|
also note adding noise in the LTS for people/clouds that don't want to move up/change their crictl/kubelet version...well think it over.. |
|
We had a discussion about that on #9315 (comment). Where we ended up is: users may upgrade directly from 1.6 (an LTS) to 2.0 or the next LTS, skipping 1.7. Omitting known deprecations from 1.6 (even if the feature isn't deprecated in 1.6) means these users might miss the warning and be surprised at upgrade. |
|
fair |
|
The warnings are a simple ID + message + timestamp right now. We could also add something like a "first-deprecated-in" output, and users running a 1.6 release but seeing a 1.7 version there could know that it's not actually deprecated in 1.6, but that they should take care when upgrading anyway. But I haven't convinced myself of that approach yet. |
|
I suppose this is one reason some projects require upgrades be sequential |
|
This is the doc I had put together on the design approach I was taking. If you look in the "Bikeshedding" section there's some discussion on the warning contents, but I hadn't gotten much feedback on it yet. |
|
should be noted that even on 1.6 v1 cri is the default |