Skip to content

Conversation

@ruiwen-zhao
Copy link
Member

@k8s-ci-robot
Copy link

Hi @ruiwen-zhao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruiwen-zhao
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link

@ruiwen-zhao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp
Copy link
Member

/ok-to-test

(I don't know why you still need this?)

@kzys kzys merged commit eb82048 into containerd:release/1.6 Nov 10, 2023
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting this is 1.6 and v1alpha2 was not officially deprecated here..

Thought it. says 1.7 :-) so the warning is still accurate, if not odd to be adding to 1.6.

Hmm

@mikebrow
Copy link
Member

also note adding noise in the LTS for people/clouds that don't want to move up/change their crictl/kubelet version...well think it over..

@samuelkarp
Copy link
Member

We had a discussion about that on #9315 (comment). Where we ended up is: users may upgrade directly from 1.6 (an LTS) to 2.0 or the next LTS, skipping 1.7. Omitting known deprecations from 1.6 (even if the feature isn't deprecated in 1.6) means these users might miss the warning and be surprised at upgrade.

@mikebrow
Copy link
Member

fair

@samuelkarp
Copy link
Member

The warnings are a simple ID + message + timestamp right now. We could also add something like a "first-deprecated-in" output, and users running a 1.6 release but seeing a 1.7 version there could know that it's not actually deprecated in 1.6, but that they should take care when upgrading anyway. But I haven't convinced myself of that approach yet.

@mikebrow
Copy link
Member

I suppose this is one reason some projects require upgrades be sequential

@samuelkarp
Copy link
Member

This is the doc I had put together on the design approach I was taking. If you look in the "Bikeshedding" section there's some discussion on the warning contents, but I hadn't gotten much feedback on it yet.

@mikebrow
Copy link
Member

should be noted that even on 1.6 v1 cri is the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants