integration: deflake TestIssue9103 #9349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: containerd#9334 Signed-off-by: Wei Fu <[email protected]>
Member
Author
|
@henry118 I can't reproduce it in my local for release/1.6. Would you please help verify this? Thanks |
henry118
approved these changes
Nov 8, 2023
Member
henry118
left a comment
henry118
left a comment
There was a problem hiding this comment.
This issue only occurs on io.containerd.runc.v1.
I cherry-picked this PR to 1.6 and ran the test case locally 100x and it looked solid. Thanks for the fix!
TEST_RUNTIME=io.containerd.runc.v1 go test -count 100 -test.root -run TestIssue9103
henry118
added
cherry-pick/1.6.x
cherry-pick/1.7.x
estesp
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
fuweid
added
cherry-picked/1.6.x
Member
|
Somehow my notifications got turned off and I missed this. Thank you for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9334