Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default enable unprivileged icmp/ports #9348

Conversation

lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Nov 8, 2023

Fixes: #6924

current we add verify kernel version when enable unprivileged #9172, so we can default enable unprivileged icmp and ports.

@k8s-ci-robot
Copy link

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot
Copy link

@henry118: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@containerd containerd deleted a comment from k8s-ci-robot Nov 9, 2023
@samuelkarp
Copy link
Member

/ok-to-test

@estesp estesp added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@kzys kzys added this pull request to the merge queue Nov 10, 2023
Merged via the queue into containerd:main with commit 67650f2 Nov 10, 2023
@samuelkarp samuelkarp added impact/changelog area/cri Container Runtime Interface (CRI) and removed kind/test labels Mar 6, 2025
samuelkarp added a commit to samuelkarp/containerd that referenced this pull request Mar 7, 2025
We changed the default setting for `enable_unprivileged_ports` and
`enable_unprivileged_icmp` in the CRI plugin in
containerd#9348, but missed including
this change in the release notes.

Signed-off-by: Samuel Karp <[email protected]>
samuelkarp added a commit to samuelkarp/containerd that referenced this pull request Mar 7, 2025
We changed the default setting for `enable_unprivileged_ports` and
`enable_unprivileged_icmp` in the CRI plugin in
containerd#9348, but missed including
this change in the release notes.

Signed-off-by: Samuel Karp <[email protected]>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/containerd that referenced this pull request Mar 7, 2025
We changed the default setting for `enable_unprivileged_ports` and
`enable_unprivileged_icmp` in the CRI plugin in
containerd#9348, but missed including
this change in the release notes.

Signed-off-by: Samuel Karp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cri Container Runtime Interface (CRI) impact/changelog ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Enable enable_unprivileged_icmp and enable_unprivileged_ports by default
6 participants