-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default enable unprivileged icmp/ports #9348
add default enable unprivileged icmp/ports #9348
Conversation
Signed-off-by: rongfu.leng <[email protected]>
Hi @lengrongfu. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@henry118: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
We changed the default setting for `enable_unprivileged_ports` and `enable_unprivileged_icmp` in the CRI plugin in containerd#9348, but missed including this change in the release notes. Signed-off-by: Samuel Karp <[email protected]>
We changed the default setting for `enable_unprivileged_ports` and `enable_unprivileged_icmp` in the CRI plugin in containerd#9348, but missed including this change in the release notes. Signed-off-by: Samuel Karp <[email protected]>
We changed the default setting for `enable_unprivileged_ports` and `enable_unprivileged_icmp` in the CRI plugin in containerd#9348, but missed including this change in the release notes. Signed-off-by: Samuel Karp <[email protected]>
Fixes: #6924
current we add verify kernel version when enable unprivileged #9172, so we can default enable unprivileged icmp and ports.