Skip to content

[release/1.7] Expose usage of cri-api v1alpha2 #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzys merged 1 commit into from
Nov 9, 2023
Merged

[release/1.7] Expose usage of cri-api v1alpha2 #9336

kzys merged 1 commit into from
Nov 9, 2023

Conversation

@ruiwen-zhao
Copy link
Member

@ruiwen-zhao ruiwen-zhao commented Nov 3, 2023 •
edited
Loading

This PR reports the usage of the deprecated v1alpha2 api by hooking warning service into instrumented_service.

Since v1alpha2 is removed from main, I am submitting the PR directly against release/1.7.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 3, 2023

Hi @ruiwen-zhao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp samuelkarp added the area/cri Container Runtime Interface (CRI) label Nov 3, 2023
@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Nov 3, 2023

cc @qiutongs

@samuelkarp
Copy link
Member

samuelkarp commented Nov 3, 2023

/ok-to-test

@dmcgowan What do we need to do for @ruiwen-zhao to no longer need approval for Prow? Looks like he's been added to the organization already.

@ruiwen-zhao ruiwen-zhao changed the title Expose usage of cri-api v1alpha2 [release/1.7] Expose usage of cri-api v1alpha2 Nov 3, 2023
samuelkarp
samuelkarp reviewed Nov 3, 2023
View reviewed changes
@samuelkarp samuelkarp mentioned this pull request Nov 3, 2023
Closed
3 tasks
samuelkarp
samuelkarp requested changes Nov 3, 2023
View reviewed changes
@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Nov 6, 2023

/cc @mikebrow

@k8s-ci-robot k8s-ci-robot requested a review from mikebrow November 6, 2023 20:04
@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Nov 7, 2023

sync'ed with @mikebrow over Slack, changing to only reporting warnings when Status() or Version() is called.

mikebrow
mikebrow approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Nov 8, 2023

/retest

@kzys kzys merged commit 4bf224b into containerd:release/1.7 Nov 9, 2023
@ruiwen-zhao ruiwen-zhao mentioned this pull request Nov 9, 2023
Merged
@kiashok kiashok mentioned this pull request Nov 14, 2023
Merged
@samuelkarp samuelkarp added the cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch label Dec 6, 2023
@SergeyKanzhelev
Copy link
Contributor

SergeyKanzhelev commented Dec 6, 2023

This PR doesn't cover a few popular use cases:

  • pid to container (monitoring scenario) - they only call list of containers without Status or Version.
  • pre-pulling of images - crictl pull is used there.

Detecting those as a minimum would be great. Ideall we should cover every method. Sicne it is alpha API I would argue there should be no perf concerns, there is always v1 API.

Also it will be great to add to logs a warning on what specific method was called which is deprecated

@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Dec 6, 2023

This PR doesn't cover a few popular use cases:

  • pid to container (monitoring scenario) - they only call list of containers without Status or Version.
  • pre-pulling of images - crictl pull is used there.

Detecting those as a minimum would be great. Ideall we should cover every method. Sicne it is alpha API I would argue there should be no perf concerns, there is always v1 API.

Also it will be great to add to logs a warning on what specific method was called which is deprecated

Yeah the use cases make sense.

One question, what is the CRI API used for mapping pid to container?

@ruiwen-zhao ruiwen-zhao mentioned this pull request Dec 6, 2023
Merged
Mengkzhaoyun pushed a commit to open-beagle/containerd that referenced this pull request Dec 20, 2023
Merge tag 'v1.7.9'
8253bbf 
containerd 1.7.9

Welcome to the v1.7.9 release of containerd!

The ninth patch release for containerd 1.7 contains various fixes and updates.

* **update runc binary to v1.1.10::** ([#9359](containerd/containerd#9359))
* **vendor: upgrade OpenTelemetry to v1.19.0 / v0.45.0** ([#9301](containerd/containerd#9301))
* **Expose usage of cri-api v1alpha2** ([#9336](containerd/containerd#9336))
* **integration: deflake TestIssue9103** ([#9354](containerd/containerd#9354))
* **fix: shimv1 leak issue** ([#9344](containerd/containerd#9344))
* **cri: add deprecation warnings for mirrors, auths, and configs** ([#9327](containerd/containerd#9327))
* **Update hcsshim tag to v0.11.4** ([#9326](containerd/containerd#9326))
* **Expose usage of deprecated features** ([#9315](containerd/containerd#9315))

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

* Samuel Karp
* Kazuyoshi Kato
* Wei Fu
* Kirtana Ashok
* Derek McGowan
* Milas Bowman
* Sebastiaan van Stijn
* ruiwen-zhao
<details><summary>28 commits</summary>
<p>

* [release/1.7] Add release notes for v1.7.9 ([#9333](containerd/containerd#9333))
  * [`4b912af52`](containerd/containerd@4b912af) Add release notes for v1.7.9
* [release/1.7 backport] update runc binary to v1.1.10 ([#9359](containerd/containerd#9359))
  * [`eff291713`](containerd/containerd@eff2917) update runc binary to v1.1.10
* [release/1.7] vendor: upgrade OpenTelemetry to v1.19.0 / v0.45.0 ([#9301](containerd/containerd#9301))
  * [`bd9428ff7`](containerd/containerd@bd9428f) vendor: upgrade OpenTelemetry to v1.19.0 / v0.45.0
* [release/1.7] Expose usage of cri-api v1alpha2 ([#9336](containerd/containerd#9336))
  * [`d62cba40c`](containerd/containerd@d62cba4) Expose usage of cri-api v1alpha2
* [release/1.7] integration: deflake TestIssue9103 ([#9354](containerd/containerd#9354))
  * [`5dbc258a8`](containerd/containerd@5dbc258) integration: deflake TestIssue9103
* [release/1.7] fix: shimv1 leak issue ([#9344](containerd/containerd#9344))
  * [`449912857`](containerd/containerd@4499128) fix: shimv1 leak issue
* [release/1.7] cri: add deprecation warnings for mirrors, auths, and configs ([#9327](containerd/containerd#9327))
  * [`152c57e91`](containerd/containerd@152c57e) cri: add deprecation warning for configs
  * [`689a1036d`](containerd/containerd@689a103) cri: add deprecation warning for auths
  * [`8c38975bf`](containerd/containerd@8c38975) cri: add deprecation warning for mirrors
  * [`1fbce40c4`](containerd/containerd@1fbce40) cri: add ability to emit deprecation warnings
* [release/1.7] Update hcsshim tag to v0.11.4 ([#9326](containerd/containerd#9326))
  * [`73f15bdb6`](containerd/containerd@73f15bd) Update hcsshim tag to v0.11.4
* [release/1.7] Expose usage of deprecated features ([#9315](containerd/containerd#9315))
  * [`60d48ffea`](containerd/containerd@60d48ff) ctr: new deprecations command
  * [`74a06671a`](containerd/containerd@74a0667) plugin: record deprecation for dynamic plugins
  * [`fa5f3c91a`](containerd/containerd@fa5f3c9) server: add ability to record config deprecations
  * [`f7880e7f0`](containerd/containerd@f7880e7) pull: record deprecation warning for schema 1
  * [`1dd2f2c02`](containerd/containerd@1dd2f2c) introspection: add support for deprecations
  * [`aaf000c18`](containerd/containerd@aaf000c) api/introspection: deprecation warnings in server
  * [`9b7ceee54`](containerd/containerd@9b7ceee) warning: new service for deprecations
  * [`b708f8bfa`](containerd/containerd@b708f8b) deprecation: new package for deprecations
</p>
</details>

* **github.com/Microsoft/hcsshim**                                                 v0.11.1 -> v0.11.4
* **github.com/cenkalti/backoff/v4**                                               v4.2.0 -> v4.2.1
* **github.com/go-logr/logr**                                                      v1.2.3 -> v1.2.4
* **github.com/grpc-ecosystem/grpc-gateway/v2**                                    v2.7.0 -> v2.16.0
* **go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc**  v0.40.0 -> v0.45.0
* **go.opentelemetry.io/otel**                                                     v1.14.0 -> v1.19.0
* **go.opentelemetry.io/otel/exporters/otlp/otlptrace**                            v1.14.0 -> v1.19.0
* **go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc**              v1.14.0 -> v1.19.0
* **go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp**              v1.14.0 -> v1.19.0
* **go.opentelemetry.io/otel/metric**                                              v0.37.0 -> v1.19.0
* **go.opentelemetry.io/otel/sdk**                                                 v1.14.0 -> v1.19.0
* **go.opentelemetry.io/otel/trace**                                               v1.14.0 -> v1.19.0
* **go.opentelemetry.io/proto/otlp**                                               v0.19.0 -> v1.0.0

Previous release can be found at [v1.7.8](https://github.com/containerd/containerd/releases/tag/v1.7.8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ruiwen-zhao @k8s-ci-robot @samuelkarp @SergeyKanzhelev @kzys @mikebrow