CRI: Handle ArgsEscaped for new Sb Server by clearing commandline in spec #9317
Conversation
The PR containerd#8198 fixed this for CRI but missed clearing the commandline in the forked SB server. This simply adds that back in Signed-off-by: James Sturtevant <[email protected]>
|
Hi @jsturtevant. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I am going to see if I can add a test that validates this, any pointers to where might be a good place would be helpful. @kiashok fyi |
|
There is an integration test for this but it was passing. I am looking into why
|
this was because the test made sure it would start but didn't exercise the |
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
fix-sbserver-windows
branch
from
b5433b5 to
a67efe8
Compare
This commit reverts e2e-win@fb105d0. The containerd main builds are fixed on Windows via: containerd/containerd#9317. Signed-off-by: Ionut Balutoiu <[email protected]>
This commit reverts e2e-win@fb105d0. The containerd main builds are fixed on Windows via: containerd/containerd#9317. Also, update the `.vscode` debug configuration by running the `./prow/update-vscode-debug-targets.py` script. Signed-off-by: Ionut Balutoiu <[email protected]>
Update fork-external main with upstream main @ 452ec25 Related work items: containerd#5890, containerd#7647, containerd#9218, containerd#9233, containerd#9258, containerd#9270, containerd#9274, containerd#9279, containerd#9283, containerd#9286, containerd#9289, containerd#9290, containerd#9294, containerd#9295, containerd#9297, containerd#9305, containerd#9306, containerd#9308, containerd#9316, containerd#9317, containerd#9319, containerd#9320, containerd#9321
6 participants
fixes: #9037
The PR #8198 fixed this for CRI but missed clearing the commandline in the forked SB server. This simply adds that back in.