Skip to content

vendor: google.golang.org/grpc v1.58.3 #9297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 1 commit into from
Oct 26, 2023
Merged

vendor: google.golang.org/grpc v1.58.3 #9297

AkihiroSuda merged 1 commit into from
Oct 26, 2023

Conversation

@milas
Copy link
Contributor

@milas milas commented Oct 25, 2023

Upgrade google.golang.org/grpc to v1.58.3 in preparation for upgrading OTel, which has a dependency on the latest version.

See also:

@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 25, 2023

Hi @milas. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@milas milas mentioned this pull request Oct 25, 2023
Merged
@thaJeztah
Copy link
Member

thaJeztah commented Oct 25, 2023

/ok-to-test

@milas
Copy link
Contributor Author

milas commented Oct 25, 2023

FYI I don't think the win2019 failures were related to these changes, it looks like something went horribly awry on the CI runner.

@samuelkarp
Copy link
Member

samuelkarp commented Oct 25, 2023

FYI I don't think the win2019 failures were related to these changes, it looks like something went horribly awry on the CI runner.

Can you rebase on the tip of main? We've disabled this CI job for now.

@milas
vendor: google.golang.org/grpc v1.58.3
856d105 
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
@milas
Copy link
Contributor Author

milas commented Oct 25, 2023

Latest CI failure is due to throttling 😅

import_test.go:81: failed to copy: httpReadSeeker: failed open: unexpected status code https://mcr.microsoft.com/v2/windows/nanoserver/blobs/sha256:5178da1ca6af8a14a235f58eb31955ca5f4c72f950d35f9bb67a8bd20232d840: 429 Too Many Requests

If someone can kick that job, hopefully this is all set!

@AkihiroSuda AkihiroSuda added this pull request to the merge queue Oct 25, 2023
Merged via the queue into containerd:main with commit c5bd5cb Oct 26, 2023
@milas milas deleted the grpc-1.58.3-main branch October 26, 2023 03:34
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 9121769: Update fork-external main with upstream main
bad3414 
Update fork-external main with upstream main @ 452ec25

Related work items: containerd#5890, containerd#7647, containerd#9218, containerd#9233, containerd#9258, containerd#9270, containerd#9274, containerd#9279, containerd#9283, containerd#9286, containerd#9289, containerd#9290, containerd#9294, containerd#9295, containerd#9297, containerd#9305, containerd#9306, containerd#9308, containerd#9316, containerd#9317, containerd#9319, containerd#9320, containerd#9321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@milas @k8s-ci-robot @thaJeztah @samuelkarp @dmcgowan @estesp @AkihiroSuda