Skip to content

add warning use inheritable Capabilities#9287

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
lengrongfu:feat/add-warning-use-inheritable
Nov 4, 2023
Merged

add warning use inheritable Capabilities#9287
samuelkarp merged 1 commit intocontainerd:mainfrom
lengrongfu:feat/add-warning-use-inheritable

Conversation

@lengrongfu
Copy link
Copy Markdown
Contributor

@lengrongfu lengrongfu commented Oct 23, 2023

fixes #8364

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 23, 2023

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

henry118
henry118 reviewed Oct 23, 2023
View reviewed changes
Comment thread pkg/cri/server/service.go Outdated
@lengrongfu lengrongfu force-pushed the feat/add-warning-use-inheritable branch from 43511fa to 1715cdc Compare October 25, 2023 07:32
@henry118
Copy link
Copy Markdown
Member

henry118 commented Oct 30, 2023

@lengrongfu the linter isn't happy. mind fixing it?

@lengrongfu lengrongfu force-pushed the feat/add-warning-use-inheritable branch 2 times, most recently from 90b4a00 to c69b397 Compare October 31, 2023 02:58
henry118
henry118 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kiashok
Copy link
Copy Markdown
Contributor

kiashok commented Nov 1, 2023

LGTM!

@kiashok
Copy link
Copy Markdown
Contributor

kiashok commented Nov 1, 2023

@lengrongfu could you backport the changes to release branches as well? Thanks.

@lengrongfu lengrongfu force-pushed the feat/add-warning-use-inheritable branch from c69b397 to cfbab16 Compare November 2, 2023 06:32
@lengrongfu
Copy link
Copy Markdown
Contributor Author

lengrongfu commented Nov 2, 2023

@lengrongfu could you backport the changes to release branches as well? Thanks.

thanks for your advice, I'm happy to do it, I'm not sure if it's by adding cherry-pick/1.6.x and cherry-pick/1.7.x label to backport the changes to release branches; if so, I don't have permission to modify the label.

If not, could you please guide me how to do this?

samuelkarp
samuelkarp reviewed Nov 2, 2023
View reviewed changes
Comment thread pkg/cri/server/service.go Outdated
@lengrongfu lengrongfu force-pushed the feat/add-warning-use-inheritable branch from cfbab16 to df19888 Compare November 2, 2023 08:15
@samuelkarp samuelkarp added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 2, 2023
@samuelkarp samuelkarp added this pull request to the merge queue Nov 4, 2023
Merged via the queue into containerd:main with commit bd2db42 Nov 4, 2023
@samuelkarp samuelkarp mentioned this pull request Nov 6, 2023
Merged
This was referenced Oct 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@henry118 henry118 henry118 approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add warning when inheritable capabilities used in CRI base_runtime_spec

5 participants

@lengrongfu @k8s-ci-robot @henry118 @kiashok @samuelkarp