Skip to content

Conversation

@milas
Copy link
Contributor

@milas milas commented Oct 20, 2023

Upgrade gRPC in anticipation of upgrading OTel, which raises the lower limit.

As gRPC upgrades have been known to cause issues, this is being done pre-emptively. Additionally, it ensures we avoid v1.58.2, which has a known CVE, but would otherwise be chosen by MVS from go mod.

See #9256.

@k8s-ci-robot
Copy link

Hi @milas. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thaJeztah
Copy link
Member

Looks like this needs a rebase; also probably should have a counterpart in main (separate from the OTEL PR?) and backported.

milas added a commit to milas/containerd that referenced this pull request Oct 25, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
Upgrade gRPC in anticipation of upgrading OTel, which raises the
lower limit.

As gRPC upgrades have been known to cause issues, this is being
done pre-emptively. Additionally, it ensures we avoid v1.58.2,
which has a known CVE, but would otherwise be chosen by MVS from
`go mod`.

Signed-off-by: Milas Bowman <[email protected]>
@milas
Copy link
Contributor Author

milas commented Oct 25, 2023

All right, pending real CI jobs succeeding, this should be all set 🤞🏻

See #9297 for the equivalent PR to main.

milas added a commit to milas/containerd that referenced this pull request Oct 25, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
@milas
Copy link
Contributor Author

milas commented Oct 26, 2023

#9297 is merged 🎉 so hopefully this is all set too

@thaJeztah
Copy link
Member

/ok-to-test

@estesp estesp merged commit bb65a3a into containerd:release/1.7 Oct 26, 2023
@milas milas deleted the grpc-1.58.3-1.7 branch October 26, 2023 16:35
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Nov 21, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
(cherry picked from commit 856d105)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Nov 21, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
(cherry picked from commit 856d105)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Nov 21, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
(cherry picked from commit 856d105)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Nov 21, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
(cherry picked from commit 856d105)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Nov 21, 2023
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
(cherry picked from commit 856d105)
Signed-off-by: Austin Vazquez <[email protected]>
juliusl pushed a commit to juliusl/containerd that referenced this pull request Jan 26, 2024
Upgrade google.golang.org/grpc to v1.58.3 in preparation for
upgrading OTel, which has a dependency on the latest version.

See also: containerd#9281.

Signed-off-by: Milas Bowman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants