Skip to content

[release/1.7] Prepare release notes for v1.7.7#9194

Merged
dmcgowan merged 1 commit intocontainerd:release/1.7from
dcantah:release-notes-1.7.7
Oct 9, 2023
Merged

[release/1.7] Prepare release notes for v1.7.7#9194
dmcgowan merged 1 commit intocontainerd:release/1.7from
dcantah:release-notes-1.7.7

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Oct 4, 2023 •
edited
Loading

No description provided.

@dcantah dcantah changed the title [release/1.7] Prepare release notes for 1.7.7 [release/1.7] Prepare release notes for v1.7.7 Oct 4, 2023
@dcantah dcantah force-pushed the release-notes-1.7.7 branch from af555f4 to c9616be Compare October 4, 2023 10:23
@dcantah dcantah marked this pull request as ready for review October 4, 2023 10:25
@dcantah dcantah force-pushed the release-notes-1.7.7 branch from c9616be to 2a86bd3 Compare October 4, 2023 20:29
@containerd containerd deleted a comment from k8s-ci-robot Oct 4, 2023
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Oct 5, 2023

For the notes, need to generate the notes without the --linkify option since the release tool errors when the pull request in the commit log message isn't found in the repo, which since we moved the history it would be in containerd. Should probably fix that in the release tool but don't need to for this release. Here is the notes generated (Showing all committers from log package).

containerd 1.7.7

Welcome to the v1.7.7 release of containerd!

The seventh patch release for containerd 1.7 contains various fixes and updates.

Notable Updates

  • Require plugins to succeed after registering readiness (#9165)
  • Handle unexpected shim kill events (#9132)
  • Build binaries with Go 1.21.1 (#9167)
  • cri: Stop recommending disable_cgroup (#9168)
  • remotes/docker: Fix MountedFrom prefixed with target repository (#9193)
  • remotes: always try to establish tls connection when tls configured (#9188)

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

Contributors

  • Sebastiaan van Stijn
  • Derek McGowan
  • Samuel Karp
  • Krisztian Litkey
  • Wei Fu
  • Stephen J Day
  • Kenfe-Mickaël Laventure
  • Iceber Gu
  • Phil Estes
  • Akihiro Suda
  • Lantao Liu
  • Maksym Pavlenko
  • Michael Crosby
  • Mike Brown
  • Daniel Nephin
  • Steve Griffith
  • Aditya Ramani
  • Andrew Pennebaker
  • Austin Vazquez
  • Brian Goff
  • Danny Canter
  • Eng Zer Jun
  • Kazuyoshi Kato
  • Kunal Kushwaha
  • Paweł Gronowski
  • Vincent Demeester
  • Vlad Ungureanu
  • ZP-AlwaysWin
  • chentanjun

Changes

22 commits

Changes from containerd/log

62 commits

    • 89c9a54 Update golangci to 1.49
    • cf26711 Update description in README
    • f9f250c Add project details
    • fb7fe3d Add github CI flow
    • 7e13034 Add go module
    • 16a3c76 Rename log import from logtest
    • 698c398 Add README
    • 87c83c4 Add license file
    • cf97778 Revert "log: define G() as a function instead of a variable"
    • 49d5aa0 log: swap logrus functions with their equivalent on default logger
    • d9a0f0f log: add package documentation and summary of package's purpose
    • c52f856 log: make Fields type a generic map[string]any
    • fd718ae log: add log.Entry type
    • 49e8720 log: define OutputFormat type
    • 4a01dcd log: define G() as a function instead of a variable
    • 8797c9e log: add all log-levels that are accepted
    • a55e526 log: group "enum" consts and touch-up docs
    • 5d70367 log: WithLogger: remove redundant intermediate var
    • 00470f6 log: SetFormat: include returns in switch
    • 943c0f8 log: remove testify dependency
    • e75b529 Move logrus setup code to log package
    • 3e0e59e Add Fields type alias to log package
    • 0c7d3d8 log/logtest: add testcase as debug field
    • ea359c3 Prevent a race condition in testHook
    • 3392f2b Use testify
    • 710599e refactor: move from io/ioutil to io and os package
    • a893d60 Add open telemetry logging hook for logrus
    • b3b88d7 add caller info to the testHook
    • 71cc86d Allow configuration of different log formats: text, json
    • 0262a13 vendor: update gotest.tools v3.0.2
    • fe866e9 Use logrus trace support.
    • 89234f6 fix-grammar-mistake
    • e16d388 Add testing log hook to context
    • 937a207 Set default log formatting to use RFC3339Nano with fixed width
    • 5e6e0e4 Update tests to use gotest.tools angel
    • 4dcee2a Licence header added
    • 780a821 Cleanup after migration
    • 1117516 Migrate to gotestyourself/assert
    • 82fdc6e Fix trace level support.
    • 58410ff Support trace level.
    • 2ae092f Remove grpclogger from log package
    • e2bb873 log: remove log "module" system
    • 3807801 update to github.com/sirupsen/logrus v1.0.0
    • 734e628 Discard grpc logs by default
    • 9a6258d vendor: sirupsen/logrus -> Sirupsen/logrus
    • 07517b7 Integrate NATS with event subsystem
    • 26ab911 log: remove crusty context, replace with shiny
    • bb3594c log: mark grpc messages with module
    • a896da3 log: add testing for context logger
    • 1830a59 log: improve module-oriented logging
    • 1a76ec0 log: replace grpc logger with logrus
    • 88fe590 log: provide simple context logging

Changes from containerd/nri

35 commits

    • 5f13915 releases: update note about 0.4.0
    • 5ecea04 ulimit-adjuster: add validation for hard limits
    • db3de10 test: exclude ulimit-adjuster from ginkgo
    • f0deb59 ulimit-adjuster: new sample plugin
    • d2dd708 Add support for rlimits
    • efaf36e api: add POSIXRlimit type
    • c83954f Merge pull request daemon crash #47 from klihub/fixes/test-compile-workflow
    • 3f092c2 .github: add test build to CI workflow.
    • 01d5f14 Add a note about NRI API stability and release notes.
    • ea9976d adaptation: add UpdateContainer tests.
    • d042d24 stub: fix plugin UpdateContainerInterface.
    • f5d0f51 plugins: update plugins for stub changes.
    • b4bd301 adaptation: update tests with stub changes.
    • 9d86150 stub: pass context to plugin event handlers.
    • 5eee915 removed link
    • c783fc7 Resolves broken podman links and adds details to help better guide people in testing.
    • da291a6 Fix ParseEventMask to produce proper masks
    • 4a4cea6 fix the NRI_PLUGIN_NAME env value when launching a pre-installed plugin
    • a67478e stub: update setIdentify to ensureIdentify
    • 841f5ed update module name of the logger plugin
    • 8d9c64d Add gitignore for build artifacts
    • c03d1be Makefile: fix 'install-*' targets.
    • ab28e71 docs: add a chapter about security considerations.
    • 2862d98 api: initialize OCI LinuxMemory resources to empty.

Dependency Changes

  • github.com/Microsoft/hcsshim v0.11.0 -> v0.11.1
  • github.com/containerd/log v0.1.0 new
  • github.com/containerd/nri v0.3.0 -> v0.4.0
  • github.com/sirupsen/logrus v1.9.0 -> v1.9.3
  • github.com/stretchr/testify v1.8.2 -> v1.8.4

Previous release can be found at v1.7.6

AkihiroSuda
AkihiroSuda reviewed Oct 5, 2023
View reviewed changes
Comment thread releases/v1.7.7.toml
* **remotes/docker: Fix MountedFrom prefixed with target repository** ([#9193](https://github.com/containerd/containerd/pull/9193))
* **remotes: always try to establish tls connection when tls configured** ([#9188](https://github.com/containerd/containerd/pull/9188))

See the changelog for complete list of changes"""
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new in v1.7.7, but we have lost this part:

containerd/releases/v1.7.0.toml

Lines 132 to 143 in 1fbd703

postface = """\
### Which file should I download?
* `containerd-<VERSION>-<OS>-<ARCH>.tar.gz`: ✅Recommended. Dynamically linked with glibc 2.31 (Ubuntu 20.04).
* `containerd-static-<VERSION>-<OS>-<ARCH>.tar.gz`: Statically linked. Expected to be used on non-glibc Linux distributions. Not position-independent.
* `cri-containerd-<VERSION>-<OS>-<ARCH>.tar.gz`: (Deprecated)
* `cri-containerd-cni-<VERSION>-<OS>-<ARCH>.tar.gz`: (Deprecated)
In addition to containerd, typically you will have to install [runc](https://github.com/opencontainers/runc/releases)
and [CNI plugins](https://github.com/containernetworking/plugins/releases) from their official sites too.
See also the [Getting Started](https://github.com/containerd/containerd/blob/main/docs/getting-started.md) documentation.
"""

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcantah @dmcgowan WDYT?

Copy link
Copy Markdown
Member Author

@dcantah dcantah Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine adding it back. Wdyt Derek?

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a way to either update the template or add sections like this for every release in a series. For now these could be added at anytime to the Github releases. We don't need to have it included here for now.

samuelkarp
samuelkarp reviewed Oct 6, 2023
View reviewed changes
Comment thread releases/v1.7.7.toml
@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 6, 2023

@dmcgowan It looks like the dependency updates section is linking to PRs in this repo rather than the dependency's repo:

image

(I'm guessing that we're just outputting the raw #48 and then GitHub is doing linking? But it's confusing when displayed like this.)

@polarathene polarathene mentioned this pull request Oct 7, 2023
Closed
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Oct 9, 2023

(I'm guessing that we're just outputting the raw #48 and then GitHub is doing linking? But it's confusing when displayed like this.)

Yeah, normally we inject the link but when we moved commits from one repo to another, the PR link creator gets confused. Can update the release-tool to try and handle it or can just block off the commit section for this release or just add a link. The # handling isn't great for commits which move around.

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 9, 2023

Maybe just add a link for this release and see if we can update the release-tool separately?

@dcantah Can you update to include the NRI change?

@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Oct 9, 2023

@dcantah Can you update to include the NRI change?

Yep, doing now

@dcantah dcantah force-pushed the release-notes-1.7.7 branch from 2a86bd3 to a34fa56 Compare October 9, 2023 18:56
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Oct 9, 2023

Opened containerd/release-tool#43 to address this case and cases like this in the future. We don't need to block this release on that though since the release tool is only run locally.

@dmcgowan dmcgowan merged commit 8c08766 into containerd:release/1.7 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@kzys kzys kzys approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dcantah @dmcgowan @samuelkarp @kzys @mxpv @estesp @AkihiroSuda @kiashok