Skip to content

Remove C implementation of epoll on arm64#919

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
coolljt0725:remove_epoll_arm64
May 26, 2017
Merged

Remove C implementation of epoll on arm64#919
crosbymichael merged 1 commit intocontainerd:masterfrom
coolljt0725:remove_epoll_arm64

Conversation

@coolljt0725
Copy link
Copy Markdown
Contributor

"golang.org/x/sys/unix" support epoll on arm64
with golang/sys@324e137
There is no need a C implementation of epoll on arm64.

Signed-off-by: Lei Jitang [email protected]

with this patch on arm64

lei@ubuntu:~/go/src/github.com/containerd/containerd$ go env | grep GOARCH
GOARCH="arm64"
lei@ubuntu:~/go/src/github.com/containerd/containerd$ make
🐳 bin/ctr
🐳 bin/containerd
🐳 bin/protoc-gen-gogoctrd
🐳 bin/dist
🐳 bin/ctrd-protobuild
🐳 bin/containerd-shim
🐳 binaries
lei@ubuntu:~/go/src/github.com/containerd/containerd$ sudo cp bin/* /usr/bin/
[sudo] password for lei:
lei@ubuntu:~/go/src/github.com/containerd/containerd$ sudo containerd --log-level debug
INFO[0000] starting containerd boot...                   module=containerd
INFO[0000] starting debug API...                         debug="/run/containerd/debug.sock" module=containerd
INFO[0000] loading monitor plugin "cgroups"...           module=containerd
INFO[0000] loading runtime plugin "linux"...             module=containerd
DEBU[0000] init db
INFO[0000] loading snapshot plugin "snapshot-overlay"...  module=containerd
INFO[0000] loading grpc service plugin "containers-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "diff-grpc"...    module=containerd
INFO[0000] loading grpc service plugin "tasks-grpc"...   module=containerd
INFO[0000] loading grpc service plugin "healthcheck-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "images-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "content-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "metrics-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "snapshots-grpc"...  module=containerd
INFO[0000] loading grpc service plugin "version-grpc"...  module=containerd
INFO[0000] starting GRPC API server...                   module=containerd
INFO[0000] containerd successfully booted in 0.022624s   module=containerd
DEBU[0009] Preparing snapshot                            key=busybox-arm64 module="containerd/snapshot" parent="sha256:f91599b3986be816a2c74a3c05fda82e1b29f55eb12bc2b54fbfdfc3b5773edc"
DEBU[0009] Getting snapshot mounts                       key=busybox-arm64 module="containerd/snapshot"
DEBU[0011] Removing snapshot                             key=busybox-arm64 module="containerd/snapshot"
DEBU[0013] Preparing snapshot                            key=busybox-arm64 module="containerd/snapshot" parent="sha256:f91599b3986be816a2c74a3c05fda82e1b29f55eb12bc2b54fbfdfc3b5773edc"

root@ubuntu:/home/lei/go/src/github.com/containerd/containerd# bin/ctr run -id busybox-arm64 -t docker.io/aarch64/busybox:latest sh
/ # ls
bin    dev    etc    home   lib    lib64  proc   root   run    sys    tmp    usr    var
/ # exit

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 26, 2017

Codecov Report

Merging #919 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   59.55%   59.55%           
=======================================
  Files           5        5           
  Lines         759      759           
=======================================
  Hits          452      452           
  Misses        199      199           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199544e...435f03d. Read the comment docs.

@dqminh
Copy link
Copy Markdown
Member

dqminh commented May 26, 2017

LGTM.

Although if arm64 is desirable, i think we probably should also have CI for it

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 9c8e3e3 into containerd:master May 26, 2017
`"golang.org/x/sys/unix"` support epoll on arm64
with golang/sys@324e137
There is no need a C implementation of epoll on arm64.

Signed-off-by: Lei Jitang <[email protected]>
@coolljt0725 coolljt0725 deleted the remove_epoll_arm64 branch May 27, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants