Remove C implementation of epoll on arm64#919
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom May 26, 2017
Merged
Remove C implementation of epoll on arm64#919crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 59.55% 59.55%
=======================================
Files 5 5
Lines 759 759
=======================================
Hits 452 452
Misses 199 199
Partials 108 108Continue to review full report at Codecov.
|
justincormack
approved these changes
May 26, 2017
Member
|
LGTM. Although if arm64 is desirable, i think we probably should also have CI for it |
Member
|
LGTM |
`"golang.org/x/sys/unix"` support epoll on arm64 with golang/sys@324e137 There is no need a C implementation of epoll on arm64. Signed-off-by: Lei Jitang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"golang.org/x/sys/unix"support epoll on arm64with golang/sys@324e137
There is no need a C implementation of epoll on arm64.
Signed-off-by: Lei Jitang [email protected]
with this patch on arm64