Skip to content

[release/1.6] Build binaries with 1.21.1#9180

Merged
estesp merged 1 commit intocontainerd:release/1.6from
Kern--:release-1.6-go-version
Oct 3, 2023
Merged

[release/1.6] Build binaries with 1.21.1#9180
estesp merged 1 commit intocontainerd:release/1.6from
Kern--:release-1.6-go-version

Conversation

@Kern--
Copy link
Copy Markdown

@Kern-- Kern-- commented Oct 2, 2023

go 1.19 is EOL and doesn't work well with windows-2019 in CI.

Cherry-pick from #9167

This should fix the windows-2019 failures.

@dmcgowan
Build binaries with 1.21.1
37c758d 
1.19 is end of life, continue to run with 1.20 but ensure builds with
1.21.

Signed-off-by: Derek McGowan <[email protected]>
(cherry-picked from 4ffa3ed)
Signed-off-by: Kern Walster <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 2, 2023

Hi @Kern--. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Kern--
Copy link
Copy Markdown
Author

Kern-- commented Oct 2, 2023

The Vagrant error seems unrelated:

Stderr: VBoxManage: error: The machine 'containerd_default_1696272853360_62439' is already locked for a session (or being unlocked)
VBoxManage: error: Details: code VBOX_E_INVALID_OBJECT_STATE (0x80bb0007), component MachineWrap, interface IMachine, callee nsISupports
VBoxManage: error: Context: "LockMachine(a->session, LockType_Write)" at line 575 of file VBoxManageModifyVM.cpp
Error: Process completed with exit code 1.

@estesp
Copy link
Copy Markdown
Member

estesp commented Oct 2, 2023

The Vagrant error seems unrelated:

Stderr: VBoxManage: error: The machine 'containerd_default_1696272853360_62439' is already locked for a session (or being unlocked)
VBoxManage: error: Details: code VBOX_E_INVALID_OBJECT_STATE (0x80bb0007), component MachineWrap, interface IMachine, callee nsISupports
VBoxManage: error: Context: "LockMachine(a->session, LockType_Write)" at line 575 of file VBoxManageModifyVM.cpp
Error: Process completed with exit code 1.

Yes, this is new and not a flake as I restarted to see if this was some temporal issue with VBox. I don't think we've ever seen this before; need to investigate so we can get release/1.6 CI working properly.

@estesp
Copy link
Copy Markdown
Member

estesp commented Oct 2, 2023

Also curious why the other 2 vagrant-centric CI jobs did not fail with this error when they all use the same core vagrant script/config? Any ideas @AkihiroSuda?

@estesp estesp merged commit 4483cbe into containerd:release/1.6 Oct 3, 2023
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 11, 2023

It looks like this PR only updated 1 of the files to go1.21.3, but all other files continue to test against go1.20.8; was that intentional?

This was referenced Oct 12, 2023
Closed
Closed
@akhilerm akhilerm mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@henry118 henry118 henry118 approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kern-- @k8s-ci-robot @estesp @thaJeztah @dmcgowan @henry118