Skip to content

[release/1.6] cri: stop recommending disable_cgroup#9169

Merged
kzys merged 1 commit intocontainerd:release/1.6from
AkihiroSuda:cherrypick-9158-1.6
Oct 6, 2023
Merged

[release/1.6] cri: stop recommending disable_cgroup#9169
kzys merged 1 commit intocontainerd:release/1.6from
AkihiroSuda:cherrypick-9158-1.6

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Sep 30, 2023

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Sep 30, 2023

CI failure doesn't seem relevant

+ build
# github.com/containerd/containerd/cmd/containerd
C:\hostedtoolcache\windows\go\1.1[9](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:10).12\x64\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-2228565713\000007.o: in function `_cgo_preinit_init':
\\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-2228565713\000007.o: in function `x_cgo_notify_runtime_init_done':
\\_\_\runtime\cgo/gcc_libinit_windows.c:105: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-2228565713\000007.o: in function `_cgo_beginthread':
\\_\_\runtime\cgo/gcc_libinit_windows.c:149: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-2228565713\000008.o: in function `x_cgo_thread_start':
\\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'
collect2.exe: error: ld returned 1 exit status

mingw32-make: *** [Makefile:202: build] Error 1
+ bin/ctr.exe
+ bin/containerd.exe
# github.com/containerd/containerd/cmd/containerd
C:\hostedtoolcache\windows\go\1.19.12\x64\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1374976886\000007.o: in function `_cgo_preinit_init':
\\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1374976886\000007.o: in function `x_cgo_notify_runtime_init_done':
\\_\_\runtime\cgo/gcc_libinit_windows.c:[10](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:11)5: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/[12](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:13).2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-[13](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:14)74976886\000007.o: in function `_cgo_beginthread':
\\_\_\runtime\cgo/gcc_libinit_windows.c:[14](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:15)9: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-1374976886\000008.o: in function `x_cgo_thread_start':
\\_\_\runtime\cgo/gcc_util.c:[18](https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169#step:6:19): undefined reference to `__imp___iob_func'
collect2.exe: error: ld returned 1 exit status

https://github.com/containerd/containerd/actions/runs/6359935741/job/17273417774?pr=9169

thaJeztah
thaJeztah approved these changes Sep 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
cri: stop recommending disable_cgroup
7a0c8b6 
Disabling cgroup is no longer needed since cgroup v2

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 8ffb03d)
(cherry-pick was not clean)
Signed-off-by: Akihiro Suda <[email protected]>
@kzys kzys merged commit 4908fef into containerd:release/1.6 Oct 6, 2023
@akhilerm akhilerm mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@henry118 henry118 henry118 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @kzys @dmcgowan @thaJeztah @henry118