[release/1.7] vendor: github.com/Microsoft/hcsshim v0.11.1#9127
Merged
estesp merged 1 commit intocontainerd:release/1.7from Sep 21, 2023
Merged
[release/1.7] vendor: github.com/Microsoft/hcsshim v0.11.1#9127estesp merged 1 commit intocontainerd:release/1.7from
estesp merged 1 commit intocontainerd:release/1.7from
Conversation
Fix closing stdin: fix an issue introduced in [v0.10.0-rc.3], which resulted in the close request not being forwarded if stdin was nil. The fix moves the nil check to after the modify request, to let the process handle it. full diff: microsoft/hcsshim@v0.11.0...v0.11.1 [v0.10.0-rc.3]: microsoft/hcsshim@3e090b0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
cc @rumpl |
estesp
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix closing stdin (microsoft/hcsshim#1899): fix an issue introduced in v0.10.0-rc.3, which resulted in the close request not being forwarded if stdin was nil. The fix moves the nil check to after the modify request, to let the process handle it.
full diff: microsoft/hcsshim@v0.11.0...v0.11.1