[release/1.7] Blockfile: Enlighten blockfile copy on Darwin#9047
Merged
fuweid merged 1 commit intocontainerd:release/1.7from Sep 1, 2023
Merged
[release/1.7] Blockfile: Enlighten blockfile copy on Darwin#9047fuweid merged 1 commit intocontainerd:release/1.7from
fuweid merged 1 commit intocontainerd:release/1.7from
Conversation
The Go stdlib does not seem to have an efficient os.File.ReadFrom routine for other platforms like it does on Linux with copy_file_range. For Darwin at least we can use clonefile in its place, otherwise if we have a sparse file we'd have a fun surprise with the io.Copy approach.. We should see if there's other platforms that we can enhance here. I've forgotten what's the right route on Windows. Signed-off-by: Danny Canter <[email protected]> (cherry picked from commit 13ff185) Signed-off-by: Danny Canter <[email protected]>
dmcgowan
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 13ff185)
Original Description
The Go stdlib does not seem to have an efficient os.File.ReadFrom routine for other platforms like it does on Linux with copy_file_range. For Darwin at least we can use clonefile in its place, otherwise if we have a sparse file we'd have a fun surprise with the io.Copy approach..
We should see if there's other platforms that we can enhance here. I've forgotten what's the right route on Windows.