Skip to content

make repositories of install dependencies configurable#9021

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
akhilerm:make-configurable-dependencies
Aug 29, 2023
Merged

make repositories of install dependencies configurable#9021
samuelkarp merged 1 commit intocontainerd:mainfrom
akhilerm:make-configurable-dependencies

Conversation

@akhilerm
Copy link
Copy Markdown
Member

@akhilerm akhilerm commented Aug 28, 2023

make repositories of dependencies like runc, crun, cni and critools configurable

@akhilerm
make repositories of install dependencies configurable
7a0ad09 
make repositories of dependencies like runc, crun, cni and critools configurable

Signed-off-by: Akhil Mohan <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 28, 2023

Hi @akhilerm. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm
Copy link
Copy Markdown
Member Author

akhilerm commented Aug 28, 2023

/cc @dmcgowan @estesp

@akhilerm
Copy link
Copy Markdown
Member Author

akhilerm commented Aug 28, 2023

Can I get an ok-to-test on this PR?

@samuelkarp samuelkarp merged commit b0a7f08 into containerd:main Aug 29, 2023
@akhilerm akhilerm deleted the make-configurable-dependencies branch August 29, 2023 12:09
This was referenced Aug 29, 2023
Merged
Merged
Thompson1985

This comment was marked as spam.

Sign in to view

@chrishenzie chrishenzie added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dcantah dcantah dcantah approved these changes

@estesp estesp Awaiting requested review from estesp

+1 more reviewer

@Thompson1985 Thompson1985 Thompson1985 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@akhilerm @k8s-ci-robot @dmcgowan @samuelkarp @dcantah @Thompson1985 @chrishenzie @fuweid