[release/1.7] Cherry-pick: [overlay] add configurable mount options to overlay snapshotter#9005
Merged
AkihiroSuda merged 2 commits intocontainerd:release/1.7from Aug 24, 2023
Merged
Conversation
Signed-off-by: Cardy.Tang <[email protected]> (cherry picked from commit b9f2e48) Signed-off-by: Wei Fu <[email protected]>
Allows default mount options to be provided through configuration. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit d115129) Signed-off-by: Wei Fu <[email protected]>
Contributor
|
❣️ |
Member
Author
dcantah
approved these changes
Aug 24, 2023
AkihiroSuda
approved these changes
Aug 24, 2023
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have several issues related to umount which can cause unexpected IO pressure. Backporting #8676 is kind of workaround for the users who are using release/1.7. They can add volatile option to avoid syncfs in the kernel (>=5.10).
Related issues: #8698, #7496, #8931, #8647 (In #8647, the container in pods failed to start and kubelet kept restart it and there were a lot of umount syscall when containerd deleted the tasks)
Cherry-pick: #8676 #8542