[release/1.7] Add blockfile snapshotter#8986
Merged
dmcgowan merged 13 commits intocontainerd:release/1.7from Aug 21, 2023
Merged
[release/1.7] Add blockfile snapshotter#8986dmcgowan merged 13 commits intocontainerd:release/1.7from
dmcgowan merged 13 commits intocontainerd:release/1.7from
Conversation
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 0c386e2) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 798dba9) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit b729962) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 1be571b) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit 7beaa5e) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit bb82f36) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Cardy.Tang <[email protected]> (cherry picked from commit 9702d4a) Signed-off-by: Danny Canter <[email protected]>
* Use direct-io mode to reduce IO. * Add testViewHook helper to recovery the backing file since the ext4 might need writable permission to handle recovery. If the backing file needs recovery and it's for View snapshot, the readonly mount will cause error. * Use 8 MiB as capacity to reduce the IO. Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 7de95cb) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit a207b43) Signed-off-by: Danny Canter <[email protected]>
Modify the loopback size in the blockfile snapshotter test setup. Set the loopback size to 16MB when the page size is greater than 4096. Signed-off-by: James Jenkins <[email protected]> (cherry picked from commit 5c480d9) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 72b7d16) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 6dfb16f) Signed-off-by: Danny Canter <[email protected]>
Pin it with 1e0d26eb2381594984ee80989c9c229dbd930d9f Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 59b0b39) Signed-off-by: Danny Canter <[email protected]>
Member
Author
|
/retest |
Member
|
We don't normally add new features, I'm OK getting this in since it is mostly experimental with no impact on existing users. I can see the value in testing alongside the sandbox work in 1.7 though. So +1 from me. |
dmcgowan
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unclear if we want this in 1.7, but given it's mostly entirely new code, regression chances seem low. This brings in every commit that touched the snapshots/blockfile directory since it was added as a few patches fixed CI flakiness and general usability.
Original Description:
A simple generic snapshotter using block files. It is designed to be cross-platform similar to the generic native snapshotter.
It can be paired with a differ to unpack in environments that do not support mounting.
Similar to #3130