Skip to content

Store container metadata in boltdb buckets#896

Merged
mlaventure merged 1 commit intocontainerd:masterfrom
dmcgowan:container-metadata-bolt
May 24, 2017
Merged

Store container metadata in boltdb buckets#896
mlaventure merged 1 commit intocontainerd:masterfrom
dmcgowan:container-metadata-bolt

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Store container values as BoltDB keys rather than JSON.

We still plan to switch to use proto encoded values but this is better than using JSON. The protos need to be refactored before using.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 24, 2017

Codecov Report

Merging #896 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   59.55%   59.55%           
=======================================
  Files           5        5           
  Lines         759      759           
=======================================
  Hits          452      452           
  Misses        199      199           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00d731...f98a4f1. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 3752565 into containerd:master May 24, 2017
@dmcgowan dmcgowan deleted the container-metadata-bolt branch May 30, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants