[release/1.7] cri: Don't use rel path for image volumes#8926
Merged
estesp merged 1 commit intocontainerd:release/1.7from Aug 7, 2023
Merged
[release/1.7] cri: Don't use rel path for image volumes#8926estesp merged 1 commit intocontainerd:release/1.7from
estesp merged 1 commit intocontainerd:release/1.7from
Conversation
|
Hi @rata. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
cc @thaJeztah |
rata
force-pushed
the
rata/runc-abs-path-1.7
branch
from
8900e38 to
f3d6ec3
Compare
rata
changed the title
Runc 1.1 throws a warning when using rel destination paths, and runc 1.2 is planning to thow an error (i.e. won't start the container). Let's just make this an abs path in the only place it might not be: the mounts created due to `VOLUME` directives in the Dockerfile. Signed-off-by: Rodrigo Campos <[email protected]> (cherry picked from commit 2d64ab8)
rata
force-pushed
the
rata/runc-abs-path-1.7
branch
from
f3d6ec3 to
4e97a11
Compare
estesp
approved these changes
Aug 7, 2023
cpuguy83
approved these changes
Aug 7, 2023
Member
|
/ok-to-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of: #8885 for 1.7.
Runc 1.1 throws a warning when using rel destination paths, and runc 1.2 is planning to thow an error (i.e. won't start the container).
Let's just make this an abs path in the only place it might not be: the mounts created due to
VOLUMEdirectives in the Dockerfile.Signed-off-by: Rodrigo Campos [email protected]
(cherry picked from commit 2d64ab8)