Skip to content

CI: move Vagrant tests to GitHub Actions (larger runners)#8919

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda:vagrant-on-gha-larger
Aug 7, 2023
Merged

CI: move Vagrant tests to GitHub Actions (larger runners)#8919
AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda:vagrant-on-gha-larger

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

We have been using Cirrus CI for running vagrant workloads as the standard runners of GHA lacks nested virtualization, but it looks like GHA with the "larger" runners support nested virtualization.

@AkihiroSuda AkihiroSuda added kind/test cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Aug 5, 2023
@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@AkihiroSuda AkihiroSuda force-pushed the vagrant-on-gha-larger branch 11 times, most recently from 73a8d43 to 0c3582e Compare August 5, 2023 12:38
@AkihiroSuda AkihiroSuda marked this pull request as ready for review August 5, 2023 12:52
@AkihiroSuda AkihiroSuda force-pushed the vagrant-on-gha-larger branch from 0c3582e to d87111f Compare August 5, 2023 12:52
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Aug 6, 2023

fixes: #7109

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have been using Cirrus CI for running vagrant workloads
as the standard runners of GHA lacks nested virtualization,
but it looks like GHA with the "larger" runners support nested
virtualization.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the vagrant-on-gha-larger branch from d87111f to 2d3360e Compare August 6, 2023 16:25
@AkihiroSuda AkihiroSuda requested a review from cpuguy83 August 7, 2023 05:41
@AkihiroSuda AkihiroSuda merged commit ce22387 into containerd:main Aug 7, 2023
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit that referenced this pull request Nov 3, 2023
This Vagrant on Mac job has been broken for a while. Instead this
change moves Vagrant to larger Linux workers that provide nested
virtualization.

Our main branch did something similar (moving to Cirrus CI to larger
GitHub-hosted runners) already as #8919.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants