Add push object#886
Merged
stevvooe merged 1 commit intocontainerd:masterfrom May 24, 2017
Merged
Conversation
dmcgowan
force-pushed
the
pusher
branch
2 times, most recently
from
5fee084 to
daa9d59
Compare
AkihiroSuda
reviewed
May 23, 2017
Member
There was a problem hiding this comment.
nit: pushes an object to a remote?
stevvooe
reviewed
May 23, 2017
Member
There was a problem hiding this comment.
I'd prefer to keep the existing naming in place.
Split resolver to only return a name with separate methods for getting a fetcher and pusher. Add implementation for push. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 59.55% 59.55%
=======================================
Files 5 5
Lines 759 759
=======================================
Hits 452 452
Misses 199 199
Partials 108 108Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split resolver to only return a name with separate methods for getting a fetcher and pusher. Add implementation for push.
There will be a couple follow ups to this PR.
content.Ingesterinterface.