Skip to content

ci: remove libseccomp-dev installation for nightly #8768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Jul 3, 2023
Merged

ci: remove libseccomp-dev installation for nightly #8768

dmcgowan merged 1 commit into from
Jul 3, 2023

Conversation

@akhilerm
Copy link
Member

@akhilerm akhilerm commented Jun 30, 2023

since libseccomp is required only for building runc and we are only building containerd binaries in nightly, the libseccomp-dev dependency is removed

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jun 30, 2023

Hi @akhilerm. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@djdongjin
Copy link
Member

djdongjin commented Jun 30, 2023

/ok-to-test

cpuguy83
cpuguy83 requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to remove lines 49-52

@akhilerm
Copy link
Member Author

akhilerm commented Jun 30, 2023

@cpuguy83 Done.

thaJeztah
thaJeztah approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jun 30, 2023
neersighted
neersighted suggested changes Jun 30, 2023
View reviewed changes
.github/workflows/nightly.yml Outdated

- name: Install dependencies
run: |
sudo add-apt-repository -y "deb [arch=arm64,s390x,ppc64el,riscv64] http://ports.ubuntu.com/ubuntu-ports/ $(lsb_release -sc) main" || true
Copy link
Contributor

@neersighted neersighted Jun 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should no longer be necessary either; the crossbuild-essential-* packages are "an {arm64,riscv,s390x,...} cross-compiler for amd64" -- we have no need for foreign-arch repositories with this change.

Copy link
Member Author

@akhilerm akhilerm Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neersighted removed the other arch repositories.

@akhilerm
ci: remove libseccomp-dev installation for nightly
a9cb609 
since libseccomp is required only for building runc and we are only
building containerd binaries in nightly, the libseccomp-dev dependency
is removed. Foreign arch repositories are now removed since
crossbuild-essential-* packages are {arm64, ppc64el,..} cross compiler
packages for amd64 and arch specific repositories are not required.

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm
Copy link
Member Author

akhilerm commented Jul 1, 2023

/retest

@akhilerm
Copy link
Member Author

akhilerm commented Jul 3, 2023

/assign @dmcgowan For merging

@dmcgowan dmcgowan merged commit d89882a into containerd:main Jul 3, 2023
@akhilerm akhilerm deleted the fix-nightly branch July 3, 2023 08:59
This was referenced Jul 3, 2023
Merged
Merged
@fuweid fuweid added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 4, 2023
This was referenced Jul 4, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@neersighted neersighted neersighted requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@akhilerm @k8s-ci-robot @djdongjin @dmcgowan @cpuguy83 @neersighted @thaJeztah @fuweid