Skip to content

fix ci Linux Integration test fail#8766

Merged
kzys merged 1 commit intocontainerd:mainfrom
lengrongfu:fix/ci-Integration-fail
Jul 18, 2023
Merged

fix ci Linux Integration test fail#8766
kzys merged 1 commit intocontainerd:mainfrom
lengrongfu:fix/ci-Integration-fail

Conversation

@lengrongfu
Copy link
Copy Markdown
Contributor

@lengrongfu lengrongfu commented Jun 30, 2023 •
edited
Loading

fixes #8765

cri-tools fix pr: kubernetes-sigs/cri-tools#1202

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 30, 2023

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lengrongfu lengrongfu changed the title fix ci Linux Integration test fail 【Draf】fix ci Linux Integration test fail Jul 3, 2023
@lengrongfu lengrongfu changed the title 【Draf】fix ci Linux Integration test fail [draft] fix ci Linux Integration test fail Jul 3, 2023
@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch from 82d0db7 to accf8e2 Compare July 3, 2023 07:56
@lengrongfu lengrongfu changed the title [draft] fix ci Linux Integration test fail fix ci Linux Integration test fail Jul 3, 2023
@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch from accf8e2 to c417a6b Compare July 3, 2023 08:07
sparr
sparr reviewed Jul 3, 2023
View reviewed changes
Comment thread script/setup/critools-version Outdated
@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch from c417a6b to bd7b7d8 Compare July 3, 2023 15:48
@sparr
Copy link
Copy Markdown

sparr commented Jul 3, 2023

If you say "fixes #8765" (or "resolves" or "closes" or similar) in the top comment then the issue will automatically get closed when this PR is merged.

@lengrongfu
Copy link
Copy Markdown
Contributor Author

lengrongfu commented Jul 3, 2023

If you say "fixes #8765" (or "resolves" or "closes" or similar) in the top comment then the issue will automatically get closed when this PR is merged.

Thank you, learned.

@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch 2 times, most recently from 16f5e89 to 180b402 Compare July 4, 2023 04:52
fuweid
fuweid reviewed Jul 7, 2023
View reviewed changes
Comment thread script/setup/critools-version Outdated
fuweid
fuweid reviewed Jul 7, 2023
View reviewed changes
Comment thread pkg/cri/sbserver/container_stats_list.go
@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch from 180b402 to 5b1f94a Compare July 7, 2023 06:38
@lengrongfu lengrongfu force-pushed the fix/ci-Integration-fail branch from 5b1f94a to 38f9bc3 Compare July 7, 2023 06:51
@slonopotamus
Copy link
Copy Markdown
Contributor

slonopotamus commented Jul 17, 2023

Can this be merged please? Randomly failing CI in PRs is kinda annoying.

@kzys kzys merged commit ef1c9f0 into containerd:main Jul 18, 2023
@kiashok kiashok mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid left review comments

@kzys kzys kzys approved these changes

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

+1 more reviewer

@sparr sparr sparr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Linux Integration fail

8 participants

@lengrongfu @k8s-ci-robot @sparr @slonopotamus @kzys @mxpv @estesp @fuweid