Setup otlp from env #8645
Merged
Setup otlp from env #8645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows standard OTLP env vars to be used for configuring tracing exporters. Note: This does mean that, as written now, if no env var is set the trace exporter will try to connect to the default OTLP address (`localhost:4318`). I've left this alone for now, but we could detect the OTLP vars ourselves and if not set don't configure the exporter. Signed-off-by: Brian Goff <[email protected]>
dmcgowan
approved these changes
Jun 6, 2023
estesp
approved these changes
Jun 6, 2023
dcantah
approved these changes
Jun 6, 2023
samuelkarp
approved these changes
Jun 7, 2023
Member
Author
|
As a note: this was backported to 1.7 in #9992 |
thaJeztah
added
the
cherry-picked/1.7.x
Member
|
I see it backported #8970 - does that one contain the same commit, or perhaps "same effect"? |
Member
Author
|
Oh yes I grabbed the PR number from the commit, didn't think to check the content of the PR. |
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
…/main Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows standard OTLP env vars to be used for configuring tracing exporters.
Note: This does mean that, as written now, if no env var is set the trace exporter will try to connect to the default OTLP address (
localhost:4318).I've left this alone for now, but we could detect the OTLP vars ourselves and if not set don't configure the exporter.
ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options