Skip to content

fix exec slow when use concurrent execs#8593

Closed
ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
ningmingxiao:fix_exec
Closed

fix exec slow when use concurrent execs#8593
ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
ningmingxiao:fix_exec

Conversation

@ningmingxiao
Copy link
Copy Markdown
Contributor

@ningmingxiao ningmingxiao commented May 29, 2023 •
edited
Loading

fix #8557

func (m *Monitor) notify(e runc.Exit) chan struct{}
....
	select {
	case s.c <- e:
		success[s.c] = struct{}{}
	case <-timer.C:
		recv = false
		failed++
	}

if use default bufferSize=32 s.c is easy to fill up (if there are many exited events to send) will retry more times until success.
if use big bufferSize "case s.c <- e" will get more chances, notify func will run faster than before
@corhere @fuweid @dmcgowan plz review my pr thank you

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 29, 2023

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ningmingxiao ningmingxiao mentioned this pull request May 29, 2023
Closed
@ningmingxiao ningmingxiao changed the title fix exec slow DRAFT: fix exec slow May 29, 2023
@ningmingxiao ningmingxiao changed the title DRAFT: fix exec slow DRAFT fix exec slow May 29, 2023
@ningmingxiao ningmingxiao changed the title DRAFT fix exec slow DRAFT:fix exec slow May 29, 2023
@ningmingxiao ningmingxiao mentioned this pull request May 30, 2023
Merged
@ningmingxiao ningmingxiao changed the title DRAFT:fix exec slow Draft:fix exec slow May 30, 2023
@ningmingxiao ningmingxiao force-pushed the fix_exec branch 3 times, most recently from 62bbb90 to 6afc8aa Compare May 31, 2023 11:57
@ningmingxiao ningmingxiao changed the title Draft:fix exec slow fix exec slow when use concurrent execs May 31, 2023
@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jun 20, 2023

this commit use another method to modify it
#8617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Concurrent task execs take significantly longer than sequentially

2 participants

@ningmingxiao @k8s-ci-robot