Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 26, 2023

  • update github.com/mistifyio/go-zfs dependency to github.com/mistifyio/go-zfs/v3,
    which contains various bugfixes, and adds go module support (which required a major
    version update): mistifyio/go-zfs@f784269...v3.0.1
  • remove github.com/pkg/errors dependency
  • various minor cleanups/fixes

Full diff: containerd/zfs@v1.0.0...v1.1.0

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah
Copy link
Member Author

once tagged, I'd like to cherry-pick this into the current release branches, so that we no longer depend on the (now obsolete) "v2+incompatible" version of go-zfs.

- update github.com/mistifyio/go-zfs dependency to github.com/mistifyio/go-zfs/v3,
  which contains various bugfixes, and adds go module support (which required a major
  version update): mistifyio/go-zfs@f784269...v3.0.1
- remove github.com/pkg/errors dependency
- various minor cleanups/fixes

Full diff: containerd/zfs@v1.0.0...v1.1.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title vendor: github.com/containerd/zfs v1.0.1-0.20230526010527-26134297cde4 vendor: github.com/containerd/zfs v1.1.0 Jul 6, 2023
@thaJeztah thaJeztah added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 6, 2023
@thaJeztah thaJeztah marked this pull request as ready for review July 6, 2023 09:57
@thaJeztah
Copy link
Member Author

This commit was now tagged as v1.1.0; https://github.com/containerd/zfs/releases/tag/v1.1.0

Updated this PR to used the tag, and moved it out of draft 👍

@fuweid PTAL 🤗

@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 6, 2023
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 6d8248b into containerd:main Jul 6, 2023
@thaJeztah thaJeztah deleted the bump_zfs branch July 6, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants