notify readiness when registered plugins are ready #8576
Conversation
Signed-off-by: Henry Wang <[email protected]>
|
Hi @henry118. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; this seems like a reasonable way to solve the "is it really ready" issue with kubelet+CRI
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
This seems reasonable to me.
|
Thanks @samuelkarp and @estesp for the review. Can we backport this patch to 1.6 and 1.7? If so I'm happy to open the PRs too. |
samuelkarp
added
cherry-pick/1.6.x
cherry-pick/1.7.x
|
Yes, I'd like to see this backported to both 1.6 and 1.7. |
|
+100 to backport |
thaJeztah
added
cherry-picked/1.6.x
6 participants
Fix: #8468
Added
RegisterReadinessfunc toInitContextto allow plugins to register themselves as required plugins which will be waited for the readiness before systemd notification is sent. This PR only registers CRI plugin to address #8468.